Skip to content

Comments

Rework page layout#4013

Open
zenoachtig wants to merge 7 commits intomainfrom
page-layout-rework
Open

Rework page layout#4013
zenoachtig wants to merge 7 commits intomainfrom
page-layout-rework

Conversation

@zenoachtig
Copy link
Contributor

@zenoachtig zenoachtig commented Feb 16, 2026

  • Introduce 3 Tailwind variants to keep track of layout: layout-default, layout-wide, layout-full.
  • Introduce CONTENT_STYLE classname constant to standardise width logic for UI (handled in CONTAINER_STYLE) and content.
  • Rework width constraints of blocks using those variants and constants, and remove individual overrides
  • Rework left & right sidebar behaviour, introduce minimal sidebar versions that are fixed to the sides.

@changeset-bot
Copy link

changeset-bot bot commented Feb 16, 2026

🦋 Changeset detected

Latest commit: 42f2076

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@argos-ci
Copy link

argos-ci bot commented Feb 16, 2026

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2-cloudflare (Inspect) ⚠️ Changes detected (Review) 116 changed, 4 removed Feb 24, 2026, 4:16 PM
customers-v2-vercel (Inspect) ⚠️ Changes detected (Review) 118 changed Feb 24, 2026, 4:09 PM
v2-vercel (Inspect) ⚠️ Changes detected (Review) 443 changed Feb 24, 2026, 4:14 PM

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 87443dbac8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

<div className="relative flex flex-col border-tint-subtle border-b theme-bold:bg-header-background">
<EmbeddableFrameHeader className="theme-bold:text-header-link">
<HeaderMobileMenu className="-ml-2 page-no-toc:hidden theme-bold:text-header-link hover:theme-bold:bg-header-link/3 hover:theme-bold:text-header-link lg:hidden" />
<HeaderMobileMenu className="-ml-2 layout-wide:hidden theme-bold:text-header-link hover:theme-bold:bg-header-link/3 hover:theme-bold:text-header-link lg:hidden" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Hide embed mobile menu only when TOC is absent

This class change inverts the menu visibility logic for embedded docs: layout-wide:hidden uses the layout-wide variant (defined in tailwind.config.ts as body:has(.layout-wide):has(.page-has-toc)), so the menu is now hidden when a TOC exists and not hidden on page-no-toc pages. On mobile embedded pages, wide layouts with a TOC lose the primary way to open navigation, while pages without a TOC still show a useless menu button.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant