use OptionsResolver in DeployKeys api

Author: fbourigault

UPGRADE.md

@@ -13,6 +13,10 @@ See [documentation](doc/customize.md) to know how to customize the client timeou
 * The `setHttpClient` method have been removed. Use a `Gitlab\HttpClient\Builder` instead. 
 * The `getHttpClient` method return type is changed to `Http\Client\Common\HttpMethodsClient`.
 
+## `Gitlab\Api\DeployKeys` changes
+
+* The `all` method now take a single argument which is an associative array of query string parameters.
+* The `ORDER_BY` and `SORT` class constants have been removed.
 
 ## `Gitlab\Api\Groups` changes
 

lib/Gitlab/Api/DeployKeys.php

@@ -2,23 +2,15 @@
 
 class DeployKeys extends AbstractApi
 {
-    const ORDER_BY = 'id';
-    const SORT = 'asc';
-
     /**
-     * @param int $page
-     * @param int $per_page
-     * @param string $order_by
-     * @param string $sort
+     * @param array $parameters
+     *
      * @return mixed
      */
-    public function all($page = 1, $per_page = self::PER_PAGE, $order_by = self::ORDER_BY, $sort = self::SORT)
+    public function all(array $parameters = [])
     {
-        return $this->get('deploy_keys', array(
-            'page' => $page,
-            'per_page' => $per_page,
-            'order_by' => $order_by,
-            'sort' => $sort
-        ));
+        $resolver = $this->createOptionsResolver();
+
+        return $this->get('deploy_keys', $resolver->resolve($parameters));
     }
 }

test/Gitlab/Tests/Api/DeployKeysTest.php

@@ -9,21 +9,14 @@ public function shouldGetAllDeployKeys()
     {
         $expectedArray = $this->getMultipleDeployKeysData();
 
-        $api = $this->getMultipleDeployKeysRequestMock('deploy_keys', $expectedArray);
-
-        $this->assertEquals($expectedArray, $api->all());
-    }
-
-    protected function getMultipleDeployKeysRequestMock($path, $expectedArray = array(), $page = 1, $per_page = 20, $order_by = 'id', $sort = 'asc')
-    {
         $api = $this->getApiMock();
         $api->expects($this->once())
             ->method('get')
-            ->with($path, array('page' => $page, 'per_page' => $per_page, 'order_by' => $order_by, 'sort' => $sort))
+            ->with('deploy_keys', array('page' => 2, 'per_page' => 5))
             ->will($this->returnValue($expectedArray))
         ;
 
-        return $api;
+        $this->assertEquals($expectedArray, $api->all(['page' => 2, 'per_page' => 5]));
     }
 
     protected function getMultipleDeployKeysData()