move sort option outside createOptionsResolver

Author: fbourigault

lib/Gitlab/Api/AbstractApi.php

@@ -194,7 +194,7 @@ protected function encodePath($path)
     }
 
     /**
-     * Create a new OptionsResolver with page, per_page and sort options.
+     * Create a new OptionsResolver with page and per_page options.
      *
      * @return OptionsResolver
      */
@@ -213,9 +213,6 @@ protected function createOptionsResolver()
                 return $value > 0 && $value <= 100;
             })
         ;
-        $resolver->setDefined('sort')
-            ->setAllowedValues('sort', ['asc', 'desc'])
-        ;
 
         return $resolver;
     }

lib/Gitlab/Api/MergeRequests.php

@@ -51,6 +51,9 @@ public function all($project_id, array $parameters = [])
         $resolver->setDefined('order_by')
             ->setAllowedValues('order_by', ['created_at', 'updated_at'])
         ;
+        $resolver->setDefined('sort')
+            ->setAllowedValues('sort', ['asc', 'desc'])
+        ;
         $resolver->setDefined('milestone');
         $resolver->setDefined('view')
             ->setAllowedValues('view', ['simple'])

lib/Gitlab/Api/Projects.php

@@ -45,6 +45,9 @@ public function all(array $parameters = [])
         $resolver->setDefined('order_by')
             ->setAllowedValues('order_by', ['id', 'name', 'path', 'created_at', 'updated_at', 'last_activity_at'])
         ;
+        $resolver->setDefined('sort')
+            ->setAllowedValues('sort', ['asc', 'desc'])
+        ;
         $resolver->setDefined('search');
         $resolver->setDefined('simple')
             ->setAllowedTypes('simple', 'bool')
@@ -187,6 +190,9 @@ public function pipelines($project_id, array $parameters = [])
         $resolver->setDefined('order_by')
             ->setAllowedValues('order_by', ['id', 'status', 'ref', 'user_id'])
         ;
+        $resolver->setDefined('sort')
+            ->setAllowedValues('sort', ['asc', 'desc'])
+        ;
 
         return $this->get($this->getProjectPath($project_id, 'pipelines'), $resolver->resolve($parameters));
     }