This repository was archived by the owner on Nov 20, 2023. It is now read-only.
Draft
Conversation
My port for 1.20 was made in haste and I botched the random block tick implemenation which introduced a major bug which caused any block which could be random ticked to be duplicated at 16 block intervals through the depth of the chunk it was in. I've located my error and corrected it, and cleaned a few things up.
My multithreading implementation in WarpDrive left a lot to be desired. Although it was an improvement from my last attempt this implementation had high memory usage along with low throughput which caused to a large amount of warp ticks to be executed well after the day had arrived and the player is awake resulting in crops rapidly growing before the players eyes. To try to improve this, I've ditched WarpDrive and migrated its core functionality to the new WarpEngine class and all of the world tick logic into dedicated Runnable classes. Instead of having three threads dedicated to different aspects of world ticking, each part of the world tick will be executed asynchronously on an available thread from the ForkJoinPool. This new implementation has a huge increase in execution throughput which in turn causes the majority of world warp ticks to complete a few world ticks later. I also added a check to make sure that worlds which don't allow for sleeping don't get their time accelerated, and tweaked the action bar text.
Owner
Author
|
If anybody would like to test this PR in its current state, download the jar here: https://github.com/Giggitybyte/SleepWarp/releases/tag/2.2.0-rc1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tick_random_blockwas enabled