Game#2
Open
GhostW1ng-Work wants to merge 24 commits into
Open
Conversation
This reverts commit 33eb5ec.
After player die return on the menu
HolyMonkey
requested changes
Jun 3, 2021
|
|
||
| private void Update() | ||
| { | ||
| transform.Translate(Vector3.left * _speed * Time.deltaTime); |
Collaborator
There was a problem hiding this comment.
Игрок двигается в пространстве а не препятствия на него
Comment on lines
+17
to
+24
| try | ||
| { | ||
| transform.position = new Vector3(_player.position.x, _player.position.y, transform.position.z); | ||
| } | ||
| catch (Exception error) | ||
| { | ||
| Debug.Log(error); | ||
| } |
| Debug.Log(error); | ||
| } | ||
| } | ||
|
|
| public void AddCoin() | ||
| { | ||
| _coinsAmount++; | ||
| Debug.Log($"Coins Amount: {_coinsAmount}"); |
Collaborator
There was a problem hiding this comment.
Убери все эти выводы в лог, не засоряй их мусором
|
|
||
| public class Player : MonoBehaviour | ||
| { | ||
| public UnityAction<int> OnCoinsAmountChanged; |
Collaborator
There was a problem hiding this comment.
Перечитай наши стандарты
| } | ||
| } | ||
|
|
||
| public void UpdateJumpInput() |
Collaborator
There was a problem hiding this comment.
Название метода не отражает суть
| using UnityEngine; | ||
|
|
||
| [RequireComponent(typeof(Animator))] | ||
|
|
| using System.Collections.Generic; | ||
| using UnityEngine; | ||
|
|
||
| public class CoinsSpawner : MonoBehaviour |
Collaborator
There was a problem hiding this comment.
Дублирует спавнер препятствий
HolyMonkey
requested changes
Jun 23, 2021
| using System.Collections.Generic; | ||
| using UnityEngine; | ||
|
|
||
| public class CoinsSpawner : MonoBehaviour |
| UpdateCameraPosition(); | ||
| } | ||
|
|
||
| public void UpdateCameraPosition() |
|
|
||
| [SerializeField] private int _health; | ||
|
|
||
| private int _coinsAmount = 0; |
|
|
||
| public class Player : MonoBehaviour | ||
| { | ||
| public event UnityAction<int> CoinsAmountChanged; |
Collaborator
There was a problem hiding this comment.
|
|
||
| public class Player : MonoBehaviour | ||
| { | ||
| public event UnityAction<int> CoinsAmountChanged; |
Collaborator
There was a problem hiding this comment.
Придумай событию предметное название. Здесь скорей что CoinAdded
| _isGrounded = true; | ||
| } | ||
|
|
||
| public void UpdateHorizontalInput() |
Collaborator
There was a problem hiding this comment.
Название метода не соответствует содержанию
Comment on lines
+28
to
+31
| public void OnCollisionEnter2D() | ||
| { | ||
| _isGrounded = true; | ||
| } |
Collaborator
There was a problem hiding this comment.
Низкая надёжность у такого метода
| } | ||
| } | ||
|
|
||
| public void UpdateJumpInputAndCheckIsGrounded() |
Collaborator
There was a problem hiding this comment.
Ужасающее название метода. И почему они опять публичные?
| ChangeVelocity(_rigidBody2D.velocity.x, _yVelocity); | ||
| } | ||
|
|
||
| public void ChangeVelocity(float xVelocity , float yVelocity) |
| _player.CoinsAmountChanged -= ChangeValue; | ||
| } | ||
|
|
||
| public void ChangeValue(int value) |
Collaborator
There was a problem hiding this comment.
Название метода слишком общее. Так 50% методов можно назвать ChangeValue
HolyMonkey
requested changes
Jul 7, 2021
|
|
||
| IEnumerator SpawnObstacles() | ||
| { | ||
| var waitForSecondsBetweenSpawn = new WaitForSeconds(_secondsBetweenSpawn); |
| _player.CoinAdded -= ChangeCoinsAmount; | ||
| } | ||
|
|
||
| public void ChangeCoinsAmount(int coinsAmount) |
HolyMonkey
requested changes
Aug 11, 2021
|
|
||
| public class CoinsSpawner : Spawner | ||
| { | ||
| private int _coinsCount = 0; |
| StartCoroutine(SpawnObstacles()); | ||
| } | ||
|
|
||
| IEnumerator SpawnObstacles() |
Collaborator
There was a problem hiding this comment.
В чём смысл по разному реализовывать спавнер препятствий и спавнер монеток? А если их реализовать одинаково то будет дубляж, подумай как это всё обобщить
| using UnityEngine; | ||
|
|
||
| [RequireComponent(typeof(Rigidbody2D))] | ||
|
|
| SetVelocity(_rigidBody2D.velocity.x, _yVelocity); | ||
| } | ||
|
|
||
| private void SetVelocity(float xVelocity , float yVelocity) |
Comment on lines
+7
to
+9
| [SerializeField] protected GameObject _prefab; | ||
| [SerializeField] protected Transform[] _spawnPoints; | ||
| [SerializeField] protected float _secondsBetweenSpawn; |
Collaborator
There was a problem hiding this comment.
protected полям это плохо ка ки пуб
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.