β‘ Optimize blocking file I/O in thumbnail save #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π‘ What
Modified
flashforge/tcp/parsers/thumbnail_info.pyto offload the synchronousopen()andwrite()operations to theasynciodefault executor.π― Why
The original implementation used blocking I/O within an
async defmethod. This caused the asyncio event loop to hang completely while the file was being written to disk, starving other tasks like heartbeats or network operations.π Measured Improvement
A benchmark script writing 50MB of data showed:
PR created automatically by Jules for task 9917476809116768482 started by @GhostTypes