DRAFT: Remove finding evidence, move to report evidence#790
Open
ColonelThirtyTwo wants to merge 1 commit intoGhostManager:masterfrom
Open
DRAFT: Remove finding evidence, move to report evidence#790ColonelThirtyTwo wants to merge 1 commit intoGhostManager:masterfrom
ColonelThirtyTwo wants to merge 1 commit intoGhostManager:masterfrom
Conversation
Evidences were initially associated with specific findings. Recently, evidences gained the ability to be associated with an entire report instead. This patch removes the ability to associate evidenes with findings, allowing only report-associated evidences. This should be more intuitive to use. The migration will move existing finding-associated evidences to the report of the findings. For most cases, this should not be an issue, however, __this may cause problems if two evidences were created with the same friendly name in the same report__.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #790 +/- ##
==========================================
- Coverage 91.34% 91.32% -0.03%
==========================================
Files 367 368 +1
Lines 20728 20562 -166
==========================================
- Hits 18935 18778 -157
+ Misses 1793 1784 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evidences were initially associated with specific findings. Recently, evidences gained the ability to be associated with an entire report instead. This patch removes the ability to associate evidenes with findings, allowing only report-associated evidences.
This should be more intuitive to use.
The migration will move existing finding-associated evidences to the report of the findings. For most cases, this should not be an issue, however, this may cause problems if two evidences were created with the same friendly name in the same report.