55 get html only an entity #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsformations from XML are thus done. Still missing is the XML schema check.
…, as this is not at hand when using JavaScript.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…E-Reference-Implementation into 54-XML-import-export
54 xml import export - forced merge after implementing most suggestions by Copilot and team member reviews.
…, the styles must be refined and perhaps the content as well.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…rences - Can enable every single constraint check
There was a problem hiding this comment.
Pull request overview
This pull request implements HTML generation functionality for PIG (Product Information Graph) package entities as part of issue #50 (Design a GUI plugin to visualize a PIG data set). The PR includes significant structural refactoring of the codebase with improvements to the schema validation, constraint checking, and multi-format support (JSON-LD, XML).
Changes:
- Added
getHTML()methods to APackage and AnEntity classes for HTML visualization - Introduced comprehensive test suites for HTML generation, XML/JSON-LD import, and metaclass operations
- Refactored constraint validation with configurable checks and expanded validation coverage
- Created JSON Schema files for JSON-LD validation and new MVF (Multi-Vocabulary Facility) for format mapping
- Reorganized file structure with
ts/subdirectory for TypeScript implementations
Reviewed changes
Copilot reviewed 33 out of 35 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/pig-package-gethtml.spec.ts | New comprehensive test suite for HTML generation from packages and entities |
| tests/unit/pig-package-constraints.spec.ts | Updated tests with new constraint types and validation scenarios |
| tests/unit/pig-metaclasses-xml.spec.ts | New test suite for XML import functionality |
| tests/unit/pig-metaclasses-jsonld.spec.ts | New test suite for JSON-LD import functionality |
| src/utils/schemas/pig/ts/pig-package-constraints.ts | Enhanced constraint validation with enumerated check types and expanded coverage |
| src/utils/schemas/pig/jsonld/*.json | New JSON Schema files for validating JSON-LD documents |
| src/utils/lib/mvf.ts | New Multi-Vocabulary Facility for mapping between formats |
| src/utils/lib/messages.ts | Updated error messages with additional codes and multilingual support |
| src/utils/lib/helpers.ts | Refactored with XML document generation utilities |
| src/utils/import/xml/import-package-xml.ts | New XML import functionality |
| src/utils/import/jsonld/import-package-jsonld.ts | Updated JSON-LD import with async schema validation |
Comments suppressed due to low confidence (5)
src/utils/import/jsonld/import-package-jsonld.ts:26
- Unused import ConstraintCheckType.
src/utils/schemas/pig/ts/pig-package-constraints.ts:58 - Unused import logger.
src/utils/schemas/pig/ts/pig-metaclasses.ts:32 - Unused import Rsp.
src/utils/schemas/pig/ts/pig-metaclasses.ts:1630 - Unused variable errorMsg.
src/utils/schemas/pig/ts/pig-metaclasses.ts:1683 - Unused variable errorMsg.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
csaenz-psg
merged commit 8c4c847
into
50-design-a-gui-plugin-to-visualize-a-pig-data-set-package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... a new pull request to merge with branch #50 as suggested by Chris.