-
Notifications
You must be signed in to change notification settings - Fork 0
55 get html only an entity #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…, the styles must be refined and perhaps the content as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements HTML generation functionality for PIG entities and packages by adding getHTML() methods to the AnEntity and APackage classes. The implementation enables rendering entity metadata, properties, and package information as HTML strings for use in a viewer plugin.
Changes:
- Implemented
AnEntity.getHTML()to generate HTML representation of entities with their properties and metadata - Implemented
APackage.getHTML()to return an array of HTML strings (package metadata + entity HTML) - Added comprehensive test suite for package HTML generation covering valid/invalid packages and multiple entities
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 16 comments.
| File | Description |
|---|---|
| src/utils/schemas/pig/ts/pig-metaclasses.ts | Implements getHTML() methods for AnEntity (lines 914-957) and APackage (lines 1277-1310) to generate HTML representations |
| tests/unit/pig-package-gethtml.spec.ts | Adds comprehensive test suite with 5 test cases covering package HTML generation, error handling, and entity filtering |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
addressed all suggestions by Copilot merge review. |
…rences - Can enable every single constraint check
csaenz-psg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few changes I'd like to see. I will check that this branch does not break the current build and approve once these are all checked.
|
Closed. Will be reinitiated as a merge with branch #50 as suggested by Chris. |
getHTML() for anEntity and aPackage implemented. With all probability the styles will have to be refined and probably the layout, as well.
This should be sufficient for a first implementation of the viewer plugin.