Prevented output of empty skip link markup.#337
Open
christophherr wants to merge 2 commits intoGetbeans:developmentfrom
Open
Prevented output of empty skip link markup.#337christophherr wants to merge 2 commits intoGetbeans:developmentfrom
christophherr wants to merge 2 commits intoGetbeans:developmentfrom
Conversation
ibes
reviewed
Sep 26, 2018
Contributor
ibes
left a comment
There was a problem hiding this comment.
Why did you get rid of the (array)?
besides of that, this would also be the solution I found.
Contributor
|
Should there be tests added to check for this behaviour? |
Member
Author
|
Arguably, keeping the (array) would prevent I've no strong preference either way. Yes, tests should be added to |
fa4224d to
93670d0
Compare
93670d0 to
f329c09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #336.