Closed
Conversation
Member
|
Hey @karrirasinmaki, Can you please update your branch? It is 904 commits behind causing a merge conflict. Does this problem exist in Beans 1.5.1? Running our test suite (on Windows) shows that this change would break things. |
Author
|
Let me take a better look on this after syncing up with the current version. |
Author
|
Hi, the problem exists till in Bean 1.5.1. This PR got changes so much it was hard for me to sync upstream to my fork. So I created new PR out of my fork's master branch from where I initially made that fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request will fix local paths given by function
beans_url_to_path(string)on some environments.The problem arose, fixed and tested on this WP Vagrant box:
https://github.com/Seravo/wordpress