Skip to content

Feature/cms13 upgrade#31

Merged
drazenstankovic merged 4 commits into
masterfrom
feature/cms13-upgrade
Jun 1, 2026
Merged

Feature/cms13 upgrade#31
drazenstankovic merged 4 commits into
masterfrom
feature/cms13-upgrade

Conversation

@drazenstankovic

Copy link
Copy Markdown
Contributor

Update for cms 13 and commerce 15

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the target framework to .NET 10.0, updates several package dependencies, replaces Newtonsoft.Json with System.Text.Json, and introduces a custom Regex-based HTML stripping method. Critical feedback has been provided regarding the change from FilteredItems to Items in ContentAreaExtensions, which bypasses authorization and publishing checks. Additionally, there are performance concerns regarding the instantiation of JsonSerializerOptions on every call in JsonExtensions, and a potential ReDoS vulnerability in StringExtensions due to the lack of a regex timeout.

Comment thread src/Geta.Optimizely.Extensions/ContentAreaExtensions.cs Outdated
Comment thread src/Geta.Optimizely.Extensions/JsonExtensions.cs Outdated
Comment thread src/Geta.Optimizely.Extensions/StringExtensions.cs Outdated
@drazenstankovic drazenstankovic marked this pull request as draft May 27, 2026 11:12
@drazenstankovic drazenstankovic marked this pull request as ready for review May 27, 2026 12:34
@drazenstankovic drazenstankovic merged commit 5fe1dee into master Jun 1, 2026
1 check passed
@drazenstankovic drazenstankovic deleted the feature/cms13-upgrade branch June 1, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants