feat(react): Deprecate usePersistedDevicePreferences and move the logic to the SDK core#2108
Merged
feat(react): Deprecate usePersistedDevicePreferences and move the logic to the SDK core#2108
Conversation
|
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds web device-preference persistence: new devicePersistence module; StreamClient/Call accept and normalize devicePersistence options and pass them into DeviceManager and concrete managers; DeviceManager and Camera/Microphone/Speaker managers persist and apply preferences via localStorage; tests, mocks, sample app, and a React hook updated. Changes
Sequence Diagram(s)sequenceDiagram
participant App as Application
participant Client as StreamClient/Call
participant DeviceMgr as DeviceManager (Camera/Mic/Speaker)
participant Storage as localStorage
Note over App,Client: Init with devicePersistence config
App->>Client: new StreamClient({ devicePersistence })
Client->>DeviceMgr: new CameraManager(call, normalizedPersistence)
Note over App,DeviceMgr: User selects or mutes device
App->>DeviceMgr: selectDevice(deviceId)
DeviceMgr->>DeviceMgr: persistPreference(deviceId, status)
DeviceMgr->>Storage: writePreferences(storageKey, preference)
Note over Client,DeviceMgr: New session / initialization
App->>Client: new StreamClient({ devicePersistence })
Client->>DeviceMgr: new MicrophoneManager(call, normalizedPersistence)
DeviceMgr->>Storage: readPreferences(storageKey)
Storage-->>DeviceMgr: stored preferences
DeviceMgr->>DeviceMgr: applyPersistedPreferences()
DeviceMgr->>DeviceMgr: selectDevice(restoredDeviceId)
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/client/src/devices/DeviceManager.ts (1)
75-96:⚠️ Potential issue | 🟠 MajorLimit persistence subscriptions to audio/video managers.
persistPreference()relies onmediaDeviceKind, which throws for non-audio/video track types. Since persistence is enabled by default, screen-share managers will hit this path and crash. Guard the subscription to audio/video only.🐛 Suggested fix
- if (this.devicePersistence.enabled) { + if ( + this.devicePersistence.enabled && + (this.trackType === TrackType.AUDIO || this.trackType === TrackType.VIDEO) + ) { this.subscriptions.push( createSubscription( combineLatest([this.state.selectedDevice$, this.state.status$]), ([selectedDevice, status]) => { this.persistPreference(selectedDevice, status); }, ), ); }
🤖 Fix all issues with AI agents
In `@packages/client/src/devices/DeviceManager.ts`:
- Around line 600-639: The function applyPersistedPreferences should
early-return when device persistence is disabled or when the track type is
neither audio nor video: add a short-circuit at the start of
applyPersistedPreferences that checks this.devicePersistence.enabled (or
equivalent flag) and this.trackType being TrackType.AUDIO or TrackType.VIDEO,
and return false if persistence is disabled or the trackType is not audio/video;
keep the rest of the logic (DevicePreferenceKey selection, readPreferences,
toPreferenceList, calling select and applyMutedState) unchanged so you only
avoid applying stored preferences in unsupported cases.
In `@packages/client/src/devices/devicePersistence.ts`:
- Around line 51-91: The writePreferences function assumes window.localStorage
is always available; wrap any localStorage access in a runtime guard and
best-effort try/catch so failures (SSR, React Native, private mode, quota
errors) don’t crash. Concretely, in writePreferences (and optionally
readPreferences) check typeof window !== 'undefined' and typeof
window.localStorage !== 'undefined' before calling setItem, and surround setItem
with a try/catch that swallows or logs the error without throwing; keep the rest
of the logic (selectedDeviceId/selectedDeviceLabel, building nextPreferences
using DevicePreferenceKey, LocalDevicePreferences and LocalDevicePreference, and
defaultDeviceId) intact so failing writes are no-ops rather than runtime
exceptions.
In `@packages/client/src/devices/SpeakerManager.ts`:
- Around line 190-197: In persistSpeakerDevicePreference, the fallback synthetic
device is created with the wrong kind; open the persistSpeakerDevicePreference
function (referencing devicePersistence, listDevices, createSyntheticDevice,
writePreferences) and change the synthetic device kind from 'videoinput' to
'audiooutput' so the created device matches a speaker before calling
writePreferences with the currentDevice and storageKey.
🧹 Nitpick comments (1)
packages/react-sdk/src/hooks/usePersistedDevicePreferences.ts (1)
10-14: Consider logging the deprecation warning only once per session.The warning currently fires on every mount and whenever
keychanges, which could be noisy in apps where the component using this hook remounts frequently. A common pattern is to use a module-level flag to ensure the warning logs only once.♻️ Suggested improvement
import { useEffect } from 'react'; +let warned = false; + /** * This hook is a no-op. Device preference persistence is now handled * by the low-level client SDK. * * `@deprecated` use the devicePreferences API of the StreamVideoClient. */ export const usePersistedDevicePreferences = (key: string = ''): void => { useEffect(() => { - console.warn( - `usePersistedDevicePreferences is deprecated. Please use the devicePreferences API of the StreamVideoClient instead.`, - ); - }, [key]); + if (!warned) { + warned = true; + console.warn( + `usePersistedDevicePreferences is deprecated. Please use the devicePreferences API of the StreamVideoClient instead.`, + ); + } + }, []); };
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/client/src/devices/__tests__/mocks.ts (1)
172-215:⚠️ Potential issue | 🟡 MinorFix removeEventListener to clear the audio track’s handlers.
The audio track’s
removeEventListenerdeletes from the video track’s handler map, so audio handlers won’t be removed.🐛 Proposed fix
- removeEventListener(type: string) { - delete track.eventHandlers[type]; - }, + removeEventListener(type: string) { + delete audioTrack.eventHandlers[type]; + },
🤖 Fix all issues with AI agents
In `@packages/client/src/devices/SpeakerManager.ts`:
- Around line 150-152: The dispose method in SpeakerManager currently uses
this.subscriptions.forEach((unsubscribe) => unsubscribe()); which returns the
callback's value and triggers a Biome error; change the implementation to avoid
returning values from forEach callbacks by either iterating with a for...of loop
over this.subscriptions and calling unsubscribe() inside the loop, or by using a
block-style callback like this.subscriptions.forEach((unsubscribe) => {
unsubscribe(); }); and then clear this.subscriptions = []; to preserve existing
behavior.
🧹 Nitpick comments (2)
packages/client/src/devices/__tests__/mocks.ts (1)
226-247: Consider moving LocalStorageMock to shared test helpers.To keep test utilities centralized, place
LocalStorageMock/createLocalStorageMockin__tests__/clientTestUtils.tsand import from there. As per coding guidelines: In test files, exclude generated code (src/gen/) from coverage and use mock helpers from tests/clientTestUtils.ts; require STREAM_API_KEY and STREAM_SECRET in .env for integration tests.packages/client/src/devices/__tests__/devicePersistence.test.ts (1)
9-10: Use shared test helpers for the localStorage mock.Import the localStorage mock from
__tests__/clientTestUtils.tsto align with test helper conventions. As per coding guidelines: In test files, exclude generated code (src/gen/) from coverage and use mock helpers from tests/clientTestUtils.ts; require STREAM_API_KEY and STREAM_SECRET in .env for integration tests.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@packages/client/src/devices/DeviceManager.ts`:
- Around line 87-95: When persistence is enabled
(this.devicePersistence.enabled) we currently create a subscription using
createSubscription(combineLatest([this.state.selectedDevice$,
this.state.status$]), ...) that always calls persistPreference(selectedDevice,
status) which in turn calls mediaDeviceKind and throws for non-audio/video
managers (e.g., screen-share). Fix by gating the subscription so it is only
created for audio/video managers (check the manager type or the
selectedDevice.kind before subscribing) and additionally add a defensive early
return at the start of persistPreference(selectedDevice, status) to no-op for
non-audio/video kinds to prevent crashes; update both the subscription creation
site and persistPreference to implement these guards (also apply the same change
to the other subscription area mentioned).
In `@packages/client/src/devices/devicePersistence.ts`:
- Around line 33-62: The availability check and read of window.localStorage can
throw in SSR/RN/privacy modes; update isLocalStorageAvailable to wrap any
window/localStorage access in a try/catch and return false on error, then have
normalize rely on that safe helper (so enabled is false when access throws), and
update readPreferences to first guard with the safe isLocalStorageAvailable and
return {} if unavailable or wrap the getItem/JSON.parse in try/catch to return
{} on error; reference the functions isLocalStorageAvailable, normalize, and
readPreferences when making the changes.
# Conflicts: # packages/client/src/devices/__tests__/MicrophoneManager.test.ts # packages/client/src/devices/__tests__/MicrophoneManagerRN.test.ts
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
packages/client/src/devices/MicrophoneManager.ts (2)
32-32: Preferimport typefor the type-only import
DevicePersistenceOptionsis a TypeScript type, never used as a value. The rest of the file is consistent —import type { INoiseCancellation }(line 2) andimport type { BrowserPermissionState }(line 8) already follow the pattern. Usingimport typehere keeps intent explicit and ensures the import is fully erased at compile time.♻️ Suggested change
-import { DevicePersistenceOptions } from './devicePersistence'; +import type { DevicePersistenceOptions } from './devicePersistence';🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/client/src/devices/MicrophoneManager.ts` at line 32, Change the value import of DevicePersistenceOptions to a type-only import: update the import statement that currently references DevicePersistenceOptions in MicrophoneManager.ts to use "import type" so the DevicePersistenceOptions type is erased at compile time and remains consistent with other type-only imports like INoiseCancellation and BrowserPermissionState.
354-357: Remove stale// enabledInCallTypecommentThe inline comment on line 355 is leftover development noise — it suggests the argument was once derived from something like
settings.mic_default_on(the "call type default"), buttrueis now passed unconditionally to always restore the persisted enabled/disabled state. Replace it with a short comment that explains the actual intent.♻️ Suggested change
- if (shouldApplyDefaults && this.devicePersistence.enabled) { - // enabledInCallType - persistedPreferencesApplied = await this.applyPersistedPreferences(true); - } + if (shouldApplyDefaults && this.devicePersistence.enabled) { + // restore the full persisted state (device id + enabled/disabled) + persistedPreferencesApplied = await this.applyPersistedPreferences(true); + }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/client/src/devices/MicrophoneManager.ts` around lines 354 - 357, Remove the stale "// enabledInCallType" comment and replace it with a concise explanatory comment clarifying the actual intent: that when shouldApplyDefaults is true and devicePersistence.enabled is set, we always restore the persisted mic enabled/disabled state by calling applyPersistedPreferences(true). Update the comment near the if block using identifiers shouldApplyDefaults, devicePersistence.enabled, and applyPersistedPreferences to note that the boolean argument forces restoration of the saved enabled state (not a call-type default).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/client/src/types.ts`:
- Around line 337-340: The declared CallConstructor field devicePersistence is
never read by the Call constructor (Call.ts) — the constructor always uses
streamClient.options.devicePersistence, so per-call values are ignored; either
remove devicePersistence from CallConstructor (if no per-call override is
intended) or wire it into the Call constructor by reading/destructuring
devicePersistence from the constructor args and using that value when
initializing the Call instance (instead of unconditionally using
streamClient.options.devicePersistence); update any places referencing
CallConstructor.devicePersistence accordingly and add a test that verifies
per-call devicePersistence takes effect if you implement the wiring option.
---
Nitpick comments:
In `@packages/client/src/devices/MicrophoneManager.ts`:
- Line 32: Change the value import of DevicePersistenceOptions to a type-only
import: update the import statement that currently references
DevicePersistenceOptions in MicrophoneManager.ts to use "import type" so the
DevicePersistenceOptions type is erased at compile time and remains consistent
with other type-only imports like INoiseCancellation and BrowserPermissionState.
- Around line 354-357: Remove the stale "// enabledInCallType" comment and
replace it with a concise explanatory comment clarifying the actual intent: that
when shouldApplyDefaults is true and devicePersistence.enabled is set, we always
restore the persisted mic enabled/disabled state by calling
applyPersistedPreferences(true). Update the comment near the if block using
identifiers shouldApplyDefaults, devicePersistence.enabled, and
applyPersistedPreferences to note that the boolean argument forces restoration
of the saved enabled state (not a call-type default).
# Conflicts: # sample-apps/react/react-dogfood/helpers/client.ts
jdimovska
approved these changes
Feb 25, 2026
Member
Author
|
@coderabbitai review |
Contributor
✅ Actions performedReview triggered.
|
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain
🏁 Script executed: Length of output: 8090 🏁 Script executed: Length of output: 6488 #!/bin/bash
echo "=== Finding all TypeScript/TSX files with usePersistedDevicePreferences ==="
rg "usePersistedDevicePreferences" -g "*.ts" -g "*.tsx" -g '!node_modules' -g '!*.test.ts' -g '!*.test.tsx'
echo -e "\n=== Checking error handling in writePreferences ==="
rg -A5 -B5 "catch.*err" packages/client/src/devices/devicePersistence.ts
echo -e "\n=== Checking SpeakerManager persistence implementation ==="
rg -A30 "applyWeb\(\)" packages/client/src/devices/SpeakerManager.ts
echo -e "\n=== Checking if ScreenShareManager passes persistence ==="
cat packages/client/src/devices/ScreenShareManager.ts | grep -A10 "constructor"
echo -e "\n=== Checking normalize function for React Native handling ==="
rg -A10 "export const normalize" packages/client/src/devices/devicePersistence.ts🧠 Learnings used |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 5
♻️ Duplicate comments (1)
packages/client/src/devices/DeviceManager.ts (1)
87-97:⚠️ Potential issue | 🟠 MajorGuard persistence paths for supported managers only.
Persistence is subscribed/applied without enforcing audio/video + non-React-Native constraints in this class. That leaves a crash path (
mediaDeviceKindthrows on unsupportedtrackType) and may run web persistence logic in shared code paths.🐛 Proposed fix
@@ - if (this.devicePersistence.enabled) { + if ( + this.devicePersistence.enabled && + !isReactNative() && + (this.trackType === TrackType.AUDIO || this.trackType === TrackType.VIDEO) + ) { this.subscriptions.push( createSubscription( combineLatest([this.state.selectedDevice$, this.state.status$]), @@ private persistPreference( selectedDevice: string | undefined, status: InputDeviceStatus, ) { + if ( + this.trackType !== TrackType.AUDIO && + this.trackType !== TrackType.VIDEO + ) { + return; + } const deviceKind = this.mediaDeviceKind; @@ protected async applyPersistedPreferences(enabledInCallType: boolean) { + if ( + !this.devicePersistence.enabled || + this.trackType !== TrackType.AUDIO && + this.trackType !== TrackType.VIDEO + ) { + return false; + } const deviceKey: DevicePreferenceKey = this.trackType === TrackType.AUDIO ? 'microphone' : 'camera';As per coding guidelines,
packages/client/**/*.{ts,tsx}: "Avoid using unguarded web-only APIs in shared code that runs on React Native".Also applies to: 576-581, 599-603
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/client/src/devices/DeviceManager.ts` around lines 87 - 97, The persistence subscription in DeviceManager (the block that pushes createSubscription combining this.state.selectedDevice$ and this.state.status$ and calling this.persistPreference) must only run for supported track types/platforms; update the guard so it checks devicePersistence.enabled AND that the current selected device’s trackType is one of the supported kinds for this.devicePersistence (or that this.devicePersistence.supportsTrackType / supportedTrackTypes includes selectedDevice.trackType) and also short-circuit on React Native (e.g., skip web-only logic when running on RN). Move the guard inside the subscription callback (or filter the combined observable) so you never call mediaDeviceKind or persistPreference for unsupported trackTypes or on RN; reference DeviceManager.persistPreference, devicePersistence, this.state.selectedDevice$, this.state.status$, and createSubscription when implementing the check.
🧹 Nitpick comments (2)
packages/client/src/devices/__tests__/MicrophoneManager.test.ts (1)
425-437: Near-duplicate tests.The new test at lines 425–430 ("should apply defaults when mic_default_on is true and enabled is pristine") is functionally identical to the existing test at lines 432–437 ("should turn the mic on when set on dashboard"). Consider removing one.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/client/src/devices/__tests__/MicrophoneManager.test.ts` around lines 425 - 437, There are two duplicate tests both calling manager.apply({ mic_default_on: true }, true) and spying on manager.enable; remove one of them (either "should apply defaults when mic_default_on is true and enabled is pristine" or "should turn the mic on when set on dashboard") to avoid redundancy, keeping the clearer test name and assertions that use vi.spyOn(manager, 'enable') and expect(enable).toHaveBeenCalled(); ensure only a single test covering manager.apply and manager.enable remains.packages/client/src/devices/DeviceManager.ts (1)
512-516: Make invalid track type errors actionable.
'Invalid track type'is too generic for debugging. Include the actual value/name.♻️ Suggested refinement
- throw new Error('Invalid track type'); + throw new Error( + `Unsupported track type for device manager: ${TrackType[this.trackType]} (${this.trackType})`, + );As per coding guidelines,
packages/**/*.{ts,tsx}: "Public API should throw descriptive errors or return typed error results consistent with existing patterns".🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/client/src/devices/DeviceManager.ts` around lines 512 - 516, In the mediaDeviceKind getter of DeviceManager (the private accessor that checks this.trackType against TrackType.AUDIO/VIDEO), replace the generic throw new Error('Invalid track type') with a descriptive error that includes the actual invalid value (e.g., this.trackType) and optionally its enum name, so callers can debug what was passed; ensure the thrown message references the TrackType value/string to make the error actionable and consistent with the project's public API error style.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/client/src/devices/__tests__/CameraManager.test.ts`:
- Around line 308-330: The test creates a CameraManager instance
(persistedManager) but never disposes it, leaking subscriptions; update the test
to clean up persistedManager by calling its dispose/close method (e.g., await
persistedManager.dispose() or persistedManager.close()) after the assertions (or
register disposal in an afterEach), ensuring any async disposal is awaited —
reference persistedManager (the CameraManager instance created around line 310)
and its apply method/use in the test so the teardown runs regardless of test
outcome.
In `@packages/client/src/devices/__tests__/DeviceManager.test.ts`:
- Around line 387-450: Tests in the persistPreference block create
TestInputMediaDeviceManager instances (constructed via new
TestInputMediaDeviceManager(...)) but never call dispose(), which can leak
subscriptions from the underlying DeviceManager; update each test that creates a
persistenceEnabledManager to call persistenceEnabledManager.dispose() at the end
(or use an afterEach that tracks and disposes created instances) so the
manager's cleanup code runs and reactive listeners/subscriptions are removed.
In `@packages/client/src/devices/__tests__/MicrophoneManager.test.ts`:
- Around line 463-480: The test creates a MicrophoneManager instance
(persistedManager) but never disposes it; after invoking
persistedManager.apply(...) ensure the manager is cleaned up by awaiting its
dispose method (e.g., call await persistedManager.dispose()) so resources are
released and spies are restored; add this disposal at the end of the test (or in
a finally block) to match the cleanup pattern used for CameraManager tests and
keep applySpy and enableSpy behavior isolated.
In `@sample-apps/react/react-dogfood/helpers/client.ts`:
- Line 2: Export the hook from the hooks barrel and update the import: add
export * from './useDeviceSelectionPreference'; to the hooks index (so the
symbol is re-exported), then change the import in client.ts to import {
isRecentDeviceSelectionEnabled } from '../hooks'; ensuring you reference the
existing isRecentDeviceSelectionEnabled function and the hooks/index.ts barrel
for the change.
In `@sample-apps/react/react-dogfood/hooks/useDeviceSelectionPreference.ts`:
- Line 5: The constant DEVICE_PREFERENCE_KEY was renamed and will silently reset
users who had the old key '@pronto/device-preferences' set to 'disabled'; add a
one-time migration in the initialization path (e.g., inside
isRecentDeviceSelectionEnabled() or the hook initializer in
useDeviceSelectionPreference.ts) that checks localStorage for the old key
'@pronto/device-preferences', if found map 'disabled' to the new boolean/flag
format (set DEVICE_PREFERENCE_KEY to false) and map any other explicit saved
value to true, write the migrated value to DEVICE_PREFERENCE_KEY, then remove
the old key so future reads use the new key only; use
localStorage.getItem/setItem/removeItem to perform the migration atomically
before returning the current preference.
---
Duplicate comments:
In `@packages/client/src/devices/DeviceManager.ts`:
- Around line 87-97: The persistence subscription in DeviceManager (the block
that pushes createSubscription combining this.state.selectedDevice$ and
this.state.status$ and calling this.persistPreference) must only run for
supported track types/platforms; update the guard so it checks
devicePersistence.enabled AND that the current selected device’s trackType is
one of the supported kinds for this.devicePersistence (or that
this.devicePersistence.supportsTrackType / supportedTrackTypes includes
selectedDevice.trackType) and also short-circuit on React Native (e.g., skip
web-only logic when running on RN). Move the guard inside the subscription
callback (or filter the combined observable) so you never call mediaDeviceKind
or persistPreference for unsupported trackTypes or on RN; reference
DeviceManager.persistPreference, devicePersistence, this.state.selectedDevice$,
this.state.status$, and createSubscription when implementing the check.
---
Nitpick comments:
In `@packages/client/src/devices/__tests__/MicrophoneManager.test.ts`:
- Around line 425-437: There are two duplicate tests both calling
manager.apply({ mic_default_on: true }, true) and spying on manager.enable;
remove one of them (either "should apply defaults when mic_default_on is true
and enabled is pristine" or "should turn the mic on when set on dashboard") to
avoid redundancy, keeping the clearer test name and assertions that use
vi.spyOn(manager, 'enable') and expect(enable).toHaveBeenCalled(); ensure only a
single test covering manager.apply and manager.enable remains.
In `@packages/client/src/devices/DeviceManager.ts`:
- Around line 512-516: In the mediaDeviceKind getter of DeviceManager (the
private accessor that checks this.trackType against TrackType.AUDIO/VIDEO),
replace the generic throw new Error('Invalid track type') with a descriptive
error that includes the actual invalid value (e.g., this.trackType) and
optionally its enum name, so callers can debug what was passed; ensure the
thrown message references the TrackType value/string to make the error
actionable and consistent with the project's public API error style.
ℹ️ Review info
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (13)
packages/client/src/Call.tspackages/client/src/devices/CameraManager.tspackages/client/src/devices/DeviceManager.tspackages/client/src/devices/MicrophoneManager.tspackages/client/src/devices/ScreenShareManager.tspackages/client/src/devices/__tests__/CameraManager.test.tspackages/client/src/devices/__tests__/DeviceManager.test.tspackages/client/src/devices/__tests__/MicrophoneManager.test.tspackages/client/src/devices/__tests__/mediaStreamTestHelpers.tspackages/client/src/types.tssample-apps/react/react-dogfood/components/MeetingUI.tsxsample-apps/react/react-dogfood/helpers/client.tssample-apps/react/react-dogfood/hooks/useDeviceSelectionPreference.ts
🚧 Files skipped from review as they are similar to previous changes (2)
- packages/client/src/Call.ts
- packages/client/src/devices/ScreenShareManager.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Overview
Deprecates
usePersistedDevicePreferenceshook as it didn't work well in all cases.From now on, the device persistence will be handled by our core SDK and will be enabled by default.
We don't remove the
usePersistedDevicePreferencesfrom the SDK yet, as that would be a breaking change. Its implementation is a no-op now, and we log a warning, asking integrators to remove it from their codebase.🎫 Ticket: https://linear.app/stream/issue/REACT-809/move-device-persistence-logic-to-the-client-package
📑 Docs: https://github.com/GetStream/docs-content/pull/993
Summary by CodeRabbit
New Features
Chores
Other