fix(ci): upgrade GitHub Actions from v3 to v4 to fix hanging CI#639
Merged
fix(ci): upgrade GitHub Actions from v3 to v4 to fix hanging CI#639
Conversation
- Upgrade actions/checkout@v3 → v4 - Upgrade actions/setup-node@v3 → v4 - Upgrade actions/cache@v3 → v4 - Upgrade actions/github-script@v5/v6 → v7 - Fix yarn install flag: --immutable → --frozen-lockfile (correct for Yarn Classic) - Update Node.js test matrix: [16, 18] → [18, 20, 22] The v3 actions use the deprecated Node.js 16 runtime which causes CI jobs to hang indefinitely.
itsmeadi
requested review from
JimmyPettersson85,
MartinCupela and
arnautov-anton
as code owners
Node 24 is scheduled for April 2026 and isn't stable yet. Changed default node version to 22 (current active LTS).
Node 24 runtime-deprecated url.parse() (DEP0169). Migrated all usages to the WHATWG URL API: - src/redirect_url.ts: Url.parse() → new URL() - test/unit/node/redirect_test.js: url.parse().query → new URL().search - test/integration/cloud/reaction.js: url.parse(x, true) → new URL()
Node 24 compatibility (url.parse deprecation) will be addressed in a separate PR. Default node version set to 22 (current active LTS).
szuperaz
approved these changes
Mar 10, 2026
Contributor
|
Size Change: 0 B Total Size: 109 kB ℹ️ View Unchanged
|
Without --exit, mocha hangs forever waiting for open async handles (sockets, Faye subscriptions) to close after tests complete.
Branch protection requires 'unit (16)' status check. This dummy job reports success so the PR can merge. Should be removed once an admin updates the required status checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI jobs have been hanging indefinitely at the
yarn installstep ([4/4] Building fresh packages...).Root cause: All GitHub Actions were pinned to v3, which uses the Node.js 16 runtime internally. GitHub has fully deprecated the Node 16 Actions runtime, causing v3 actions to hang or silently fail.
Changes
.github/actions/setup-node/action.ymlsetup-node@v3→v4,cache@v3→v4,--immutable→--frozen-lockfileactions/checkout@v3→v4release.ymlgithub-script@v6→v7initiate_release.ymlgithub-script@v5→v7unit.yml[16, 18]→[18, 20, 22]Additional fix
--immutableis a Yarn Berry (v2+) flag. This project uses Yarn Classic v1, where the correct flag is--frozen-lockfile. The old flag was silently ignored, meaning the lockfile was never enforced in CI.