Skip to content

feat(ios): improved frame rendering #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
santhoshvai wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −4
Draft

feat(ios): improved frame rendering #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ios/RCTWebRTC/RTCVideoViewManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#if TARGET_OS_OSX
#import <WebRTC/RTCMTLNSVideoView.h>
#else
#import <WebRTC/RTCMTLVideoView.h>
#import <WebRTC/RTCVideoRenderingView.h>
#endif
#import <WebRTC/RTCCVPixelBuffer.h>
#import <WebRTC/RTCVideoFrame.h>
Expand Down Expand Up @@ -67,7 +67,7 @@ @interface RTCVideoView : RCTView
#if TARGET_OS_OSX
@property(nonatomic, readonly) RTCMTLNSVideoView *videoView;
#else
@property(nonatomic, readonly) RTCMTLVideoView *videoView;
@property(nonatomic, readonly) RTCVideoRenderingView *videoView;
#endif

/**
Expand Down Expand Up @@ -124,7 +124,8 @@ - (instancetype)initWithFrame:(CGRect)frame {
subview.wantsLayer = true;
_videoView = subview;
#else
RTCMTLVideoView *subview = [[RTCMTLVideoView alloc] initWithFrame:CGRectZero];
RTCVideoRenderingView *subview = [[RTCVideoRenderingView alloc] initWithFrame:CGRectZero];
subview.renderingBackend = RTCVideoRenderingBackendSharedMetal;
_videoView = subview;
#endif
[self addSubview:self.videoView];
Expand Down
2 changes: 2 additions & 0 deletions ios/RCTWebRTC/WebRTCModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,8 @@ - (instancetype)init {
audioProcessingModule:nil];
}

_peerConnectionFactory.frameBufferPolicy = RTCFrameBufferPolicyConvertWithPoolToNV12;

_rtcAudioDeviceModuleObserver = [[AudioDeviceModuleObserver alloc] initWithWebRTCModule:self];
_audioDeviceModule = [[AudioDeviceModule alloc] initWithSource:_peerConnectionFactory.audioDeviceModule
delegateObserver:_rtcAudioDeviceModuleObserver];
Expand Down
2 changes: 1 addition & 1 deletion stream-react-native-webrtc.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Pod::Spec.new do |s|
s.swift_version = '5.0'
s.dependency 'React-Core'
# WebRTC version from https://github.com/GetStream/stream-video-swift-webrtc releases
s.dependency 'StreamWebRTC', '~>137.0.54'
s.dependency 'StreamWebRTC', '~>137.0.62'
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

# Find and display the podspec file
find . -name "stream-react-native-webrtc.podspec" -type f

Repository: GetStream/react-native-webrtc

Length of output: 109

🏁 Script executed:

# Once found, check the content around line 24
cat -n stream-react-native-webrtc.podspec | sed -n '20,30p'

Repository: GetStream/react-native-webrtc

Length of output: 622

🌐 Web query:

StreamWebRTC 137.0.62 CocoaPods pod version

💡 Result:

There is no standalone CocoaPods pod named StreamWebRTC. Stream distributes StreamWebRTC primarily as a Swift Package (GetStream/stream-video-swift-webrtc). [2]

With CocoaPods, StreamWebRTC is consumed as a vendored XCFramework inside the StreamVideo pod, and the podspec’s prepare_command downloads a specific StreamWebRTC release zip from GitHub. For example, StreamVideo 1.41.0 downloads StreamWebRTC 137.0.54 (not 137.0.62). [1]

So, StreamWebRTC 137.0.62 has no “CocoaPods pod version” mapping—to use 137.0.62, you’d need either:

  • SwiftPM .exact("137.0.62") (if that tag exists in the repo), or
  • a StreamVideo podspec (or fork) whose prepare_command points at .../releases/download/137.0.62/StreamWebRTC.xcframework.zip. [3]

Sources:
[1] StreamVideo podspec showing vendored_frameworks + download URL in prepare_command (downloads 137.0.54)
[2] Stream’s WebRTC-for-Swift page describing StreamWebRTC as a Swift Package
[3] Swift Package Index page for StreamWebRTC (package versions)

🏁 Script executed:

# Check if StreamWebRTC is registered on CocoaPods at all
# Also check the full podspec to understand the dependency pattern
head -40 ./stream-react-native-webrtc.podspec

Repository: GetStream/react-native-webrtc

Length of output: 1359

🏁 Script executed:

# Check git history to see what the previous version was
git log --oneline -n 20 -- stream-react-native-webrtc.podspec | head -5
git show HEAD:stream-react-native-webrtc.podspec | grep -A2 -B2 "StreamWebRTC" || echo "Not found in HEAD"

Repository: GetStream/react-native-webrtc

Length of output: 403

🌐 Web query:

GetStream StreamWebRTC CocoaPods pod registry

💡 Result:

StreamWebRTC (GetStream’s prebuilt WebRTC XCFramework) is not published as a standalone CocoaPods pod in the CocoaPods trunk/registry (there’s no StreamWebRTC page on CocoaPods.org).

Instead, GetStream distributes it in two main ways:

  1. Via the StreamVideo CocoaPod (recommended if you’re using Stream Video).
    StreamVideo’s podspec vendors Frameworks/StreamWebRTC.xcframework and its prepare_command downloads StreamWebRTC.xcframework.zip from the GetStream/stream-video-swift-webrtc GitHub Releases page during pod install. [1]

  2. Via Swift Package Manager (SPM) as the StreamWebRTC package from GetStream/stream-video-swift-webrtc (also listed on Swift Package Registry sites). [2][3]

Sources: StreamVideo podspec (shows vendored StreamWebRTC.xcframework + download URL) [1], Stream’s iOS Video installation docs (SPM dependency example) [2], Swift Package Registry listing for GetStream/stream-video-swift-webrtc [3].

🏁 Script executed:

# Check git history for this line
git log -p --all -- stream-react-native-webrtc.podspec | grep -A5 -B5 "StreamWebRTC" | head -40

Repository: GetStream/react-native-webrtc

Length of output: 55

🏁 Script executed:

# Check if StreamVideo pod might be the correct dependency
git log --all --source --remotes -- stream-react-native-webrtc.podspec | head -20

Repository: GetStream/react-native-webrtc

Length of output: 689

🌐 Web query:

react-native-webrtc GetStream StreamWebRTC dependency CocoaPods pod install

💡 Result:

If you’re integrating GetStream Video in React Native, you generally should not use react-native-webrtc (community) on iOS—Stream’s SDK expects @stream-io/react-native-webrtc. Stream’s install docs explicitly list @stream-io/react-native-webrtc as the required peer dependency and then npx pod-install for iOS. [1]

What to do (iOS / CocoaPods)

  1. Use Stream’s WebRTC package (not react-native-webrtc)
yarn add `@stream-io/video-react-native-sdk`
yarn add `@stream-io/react-native-webrtc` react-native-svg `@react-native-community/netinfo`
npx pod-install

[1]

  1. Make sure your iOS deployment target is high enough
    If pod install fails with “could not find compatible versions for pod react-native-webrtc”, the common fix is raising:
platform :ios, '12.0'

(or higher) in ios/Podfile. [2]

  1. Match React Native version ↔︎ @stream-io/react-native-webrtc version
    Stream notes that @stream-io/react-native-webrtc >= 125.3.0 requires RN 0.73+; if you’re on older RN, pin @stream-io/react-native-webrtc@125.2.1. [1]

If you paste the exact pod install error output (the failing Pod + message), I can point to the specific Podfile change needed.

Sources:
[1] Stream Video React Native installation docs (peer deps + npx pod-install, RN version note) https://getstream.io/video/docs/react-native/setup/installation/react-native/
[2] Pod compatibility fix by raising iOS platform version for react-native-webrtc https://stackoverflow.com/questions/76089706/cocoapods-could-not-find-compatible-versions-for-pod-react-native-webrtc

🏁 Script executed:

# Check if there's a Podfile or other configuration that might set up private specs
find . -name "Podfile" -o -name ".podspec" | head -10

Repository: GetStream/react-native-webrtc

Length of output: 188

🏁 Script executed:

# Check the PR referenced in the comment to understand the intent
# Look at the full podspec for any clues about how StreamWebRTC should be accessed
cat -n stream-react-native-webrtc.podspec

Repository: GetStream/react-native-webrtc

Length of output: 1562

🌐 Web query:

GetStream/stream-video-swift-webrtc 137.0.62 CocoaPods podspec distribution

💡 Result:

GetStream/stream-video-swift-webrtc (product StreamWebRTC) is not distributed via CocoaPods (no published pod / trunk podspec). Stream documents it as a Swift Package Manager dependency that points to precompiled WebRTC XCFramework binaries hosted via the Git repo/tags (e.g., you select an exact version/tag like 137.0.62). [1], [2]

So for 137.0.62, you should consume it via SPM, not pod install. If you must use CocoaPods, you’ll need a different WebRTC binary pod/spec repo (not this GetStream package). [1], [3]

Sources:
[1] GetStream “WebRTC for Swift Developers” (SPM-only instructions) (getstream.io)
[2] Swift Package Index listing for GetStream/stream-video-swift-webrtc (SPM package/versions) (swiftpackageindex.com)
[3] CocoaPods Trunk / Specs distribution background (blog.cocoapods.org)

Citations:

Remove or replace the broken CocoaPods dependency on line 24.

StreamWebRTC is not published as a standalone CocoaPods pod. It is only available as a Swift Package Manager package or as a vendored XCFramework within the StreamVideo CocoaPods pod. The s.dependency 'StreamWebRTC', '~>137.0.62' declaration on line 24 will cause pod install to fail with "Unable to find a specification for StreamWebRTC".

To use StreamWebRTC 137.0.62, either:

  • Remove this dependency and use SPM instead for iOS WebRTC support, or
  • Replace it with a dependency on the StreamVideo pod (which vendors StreamWebRTC internally) and update the version to one that includes WebRTC 137.0.62
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@stream-react-native-webrtc.podspec` at line 24, The podspec contains a broken
CocoaPods dependency declaration s.dependency 'StreamWebRTC', '~>137.0.62' which
will cause pod install to fail because StreamWebRTC isn't published as a
standalone pod; remove that dependency or replace it with a valid CocoaPods pod
that vendors WebRTC (e.g., use the StreamVideo pod that includes the vendored
XCFramework). Update the podspec by deleting the s.dependency 'StreamWebRTC'
line and either rely on SPM for StreamWebRTC or add/replace with s.dependency
'StreamVideo', '<appropriate-version-that-includes-137.0.62>' (ensure the chosen
StreamVideo version actually vendors WebRTC 137.0.62).

# Swift/Objective-C compatibility #https://blog.cocoapods.org/CocoaPods-1.5.0/
s.pod_target_xcconfig = {
'DEFINES_MODULE' => 'YES'
Expand Down
Loading