-
Notifications
You must be signed in to change notification settings - Fork 624
fix: close AsyncStream client on session end #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
20728cf
fix: close AsyncStream client on session end
aliev a15edb7
fix: close HTTP clients in ElevenLabs TTS and Deepgram STT
aliev 9a7ba0b
fix: store ConnectionManager early and call leave() in StreamEdge.clo…
aliev 0ab5a59
fix: log exceptions in StreamEdge.close() instead of silencing
aliev ed836de
fix: add exception handling to ElevenLabs TTS and Deepgram STT close()
aliev 69930c5
fix: add exception handling to AsyncStream client close
aliev 7a8c189
refactor: remove redundant try/except where _apply() already handles it
aliev b27a10c
test: verify StreamEdge.close() releases client and connection
aliev 228f65b
fix: use correct httpx client path in ElevenLabs TTS and Deepgram STT…
aliev 1bfa9e2
fix: call super().close() in ElevenLabs TTS, clean up getattr chains
aliev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| from vision_agents.plugins import deepgram | ||
|
|
||
|
|
||
| class TestDeepgramSTTClose: | ||
| async def test_close_closes_http_client(self): | ||
| stt = deepgram.STT(api_key="fake") | ||
| httpx_client = stt.client._client_wrapper.httpx_client.httpx_client | ||
|
|
||
| assert httpx_client.is_closed is False | ||
| await stt.close() | ||
| assert httpx_client.is_closed is True |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| from vision_agents.plugins import elevenlabs | ||
|
|
||
|
|
||
| class TestElevenLabsTTSClose: | ||
| async def test_close_closes_http_client(self): | ||
| tts = elevenlabs.TTS(api_key="fake") | ||
| httpx_client = tts.client._client_wrapper.httpx_client.httpx_client | ||
|
|
||
| assert httpx_client.is_closed is False | ||
| await tts.close() | ||
| assert httpx_client.is_closed is True |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.