docs: Move autocomplete stories to v9 storybook #2888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved and renamed the following files from docs/components/Autocomplete to packages/components/src/Autocomplete: - Web.stories.tsx → Autocomplete.stories.tsx - WebV2.stories.tsx → AutocompleteV2.stories.tsx - V1.docgen.tsx → V1.docgen.tsx (no rename needed) - V2.docgen.tsx → V2.docgen.tsx (no rename needed) These files will be modernized in a subsequent commit.
Updated both Autocomplete.stories.tsx and AutocompleteV2.stories.tsx to use v9 patterns:
1. Updated meta export format:
- Changed from `as ComponentMeta<T>` to `satisfies ComponentMeta<T>`
- Added `type Story = ComponentStory<typeof meta>`
- Removed unnecessary parameters (previewTabs)
- Updated title paths (removed /Web suffix)
2. Updated story definitions:
- Changed from `.bind({})` pattern to object format with `render` property
- Used `Story` type for all exported stories
- Preserved all existing args and functionality
Files modified:
- Autocomplete.stories.tsx (v1 stories)
- AutocompleteV2.stories.tsx (v2 stories)
jdeichert
commented
Jan 22, 2026
|
|
||
| [Autocomplete docs](https://atlantis.getjobber.com/components/Autocomplete) have moved to the new site. | ||
|
|
||
| [Web](https://atlantis.getjobber.com/storybook/web/?path=/story/components-forms-and-inputs-autocomplete--basic) stories have moved to Storybook v9. |
jdeichert
commented
Jan 22, 2026
| @@ -0,0 +1,200 @@ | |||
| --- | |||
Contributor
Author
There was a problem hiding this comment.
Should work in Cursor, though I haven't tested that.
jdeichert
commented
Jan 22, 2026
| <Autocomplete | ||
| {...args} | ||
| value={value} | ||
| placeholder={args?.placeholder ?? ""} |
Contributor
Author
There was a problem hiding this comment.
TS was complaining about args.placeholder being undefined possibly 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations
We need to migrate stories from v7 to v9 web/mobile storybooks.
This PR migrates Autocomplete stories and also adds a Claude Skill which can be used to do ~90% of the migration.
Before
After
Changes
Changed
Testing
npm run storybookcd packages/components && npm run storybookcd packages/site && npm run devChanges can be
tested via Pre-release
In Atlantis we use Github's built in pull request reviews.