Changed the install script to detect ARM architecture #14
Conversation
…r not If an ARM device is used, it will use a python script to fetch the latest daily, as per committing, there was not yet a stable LTR ARM version of Rstudio available.
GreatEmerald
left a comment
GreatEmerald
left a comment
There was a problem hiding this comment.
The changes are a bit too extensive than needed, see comments.
There was a problem hiding this comment.
This is overly complicated, I think. It would take more effort to run it than to set the new version manually. At most some simple Bash script could work, but we can just omit these.
| vars: | ||
| rstudio_version: 2025.05.1-513 | ||
| rstudio_branch: jammy | ||
| rstudio_branch: "{{ ubuntu_codename | default('jammy') }}" |
There was a problem hiding this comment.
We don't want to pass the codename. As you can see, this is Noble, but the branch is Jammy. It wouldn't work with "Noble", as RStudio people are lazy and don't maintain multiple versions as long as deps don't break.
There was a problem hiding this comment.
These are also a bit too extensive changes. Just add a minimal check for the arch. You can literally just pass system_arch=$(uname -m) (or uname -i, not sure which one is set on ARM, or maybe both as on x86_64)
|
I'll try to integrate this today, if I have enough time! |
2 participants
If an ARM device is used, it will use a python script to fetch the latest daily, as per committing, there was not yet a stable LTR ARM version of Rstudio available.