fix(mcp): update MCP configuration example to use array command format#89
Open
pablon wants to merge 1 commit intoGentleman-Programming:mainfrom
Open
fix(mcp): update MCP configuration example to use array command format#89pablon wants to merge 1 commit intoGentleman-Programming:mainfrom
pablon wants to merge 1 commit intoGentleman-Programming:mainfrom
Conversation
- Replace separate command/args fields with combined command array - Add enabled field to match current MCP schema Fixes Gentleman-Programming#88 Signed-off-by: pablon <73798198+pablon@users.noreply.github.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace separate command/args fields with combined command array in mcp config directions when running
engram --help🔗 Linked Issue
Closes #88
🏷️ PR Type
type:bug— Bug fixtype:feature— New featuretype:docs— Documentation onlytype:refactor— Code refactoring (no behavior change)type:chore— Maintenance, dependencies, toolingtype:breaking-change— Breaking change📝 Summary
📂 Changes
cmd/engram/main.go--help output🧪 Test Plan
go test ./...go test -tags e2e ./internal/server/...In
opencode.json:{ "mcp": { "engram": { "type": "local", "command": ["engram", "mcp", "--tools=agent"], "enabled": true } }opencode mcp listcommand output:opencodeopens without errors ✅🤖 Automated Checks
These run automatically and all must pass before merge:
Closes #N/Fixes #N/Resolves #Nstatus:approvedlabeltype:*labelgo test ./...passesgo test -tags e2e ./internal/server/...passes✅ Contributor Checklist
Closes #N)type:*label to this PRgo test ./...go test -tags e2e ./internal/server/...Co-Authored-Bytrailers in commits💬 Notes for Reviewers