fix(scripts): iterate all skill dirs instead of hardcoded glob#42
Open
klewicki7 wants to merge 2 commits intoGentleman-Programming:mainfrom
Open
fix(scripts): iterate all skill dirs instead of hardcoded glob#42klewicki7 wants to merge 2 commits intoGentleman-Programming:mainfrom
klewicki7 wants to merge 2 commits intoGentleman-Programming:mainfrom
Conversation
added 2 commits
March 17, 2026 00:07
The install_skills() function only iterated over sdd-* and skill-registry directories. Skills issue-creation and branch-pr were added in f22181c but never included in the installer glob, so they were silently skipped during setup. Closes Gentleman-Programming#41
The install_skills() function used a hardcoded glob (sdd-* + skill-registry) that silently skipped any skill not matching those patterns. This already caused two incidents (Gentleman-Programming#30, Gentleman-Programming#41) where new skills were not installed. Replace the explicit glob with a dynamic iteration over all subdirectories containing a SKILL.md, excluding _shared which is handled separately. Future skills will be picked up automatically without modifying the installer. Closes Gentleman-Programming#41
There was a problem hiding this comment.
Pull request overview
This PR updates the full setup script to install skills by dynamically scanning the skills/ directory rather than relying on a hardcoded glob, preventing newly added skills from being skipped during installation.
Changes:
- Replace the hardcoded
sdd-*/skill-registryglob ininstall_skills()with iteration over allskills/*/subdirectories. - Skip
_shared/during the main loop since it is already copied separately. - Only install directories that contain a
SKILL.md.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sdd-*/ skill-registry/) eninstall_skills()por una iteración dinámica sobre todos los subdirectorios deskills/que contengan unSKILL.md_shared/que ya se maneja por separado antes del loopContexto
El glob hardcodeado ya causó dos incidentes:
skill-registryno se copiabaissue-creationybranch-prno se copiabanEn lugar de seguir agregando entradas al glob manualmente, esta PR elimina el patrón por completo.
Closes #41
Test plan
./scripts/setup.sh --ally verificar que todos los skills se copian (incluyendoissue-creationybranch-pr)_shared/NO se duplica (ya se copia antes del loop)skills/test-skill/SKILL.mdy confirmar que se instala sin modificar el scriptSKILL.mdse ignoran correctamente