Skip to content

deprecate tot_nitro slot #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mslarae13 wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

deprecate tot_nitro slot #751

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08074c1
remove tot_nitro slot
mslarae13 Jan 13, 2024
1ed5f5f
replace tot_nitro slot in extenstion classes with tot_nitro_content, …
mslarae13 Jan 13, 2024
9436445
replace tot_nitro slot in extension classes with tot_nitro_content, a…
mslarae13 Jan 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 10 additions & 27 deletions src/mixs/schema/mixs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14360,29 +14360,6 @@ slots:
syntax: ^{scientific_float}( *- *{scientific_float})? *{text}$
interpolated: true
partial_match: true
tot_nitro:
annotations:
Preferred_unit:
tag: Preferred_unit
value: microgram per liter, micromole per liter, milligram per liter
description: 'Total nitrogen concentration of water samples, calculated by: total
nitrogen = total dissolved nitrogen + particulate nitrogen. Can also be measured
without filtering, reported as nitrogen'
title: total nitrogen concentration
examples:
- value: 50 micromole per liter
keywords:
- concentration
- nitrogen
- total
slot_uri: MIXS:0000102
range: string
pattern: ^[-+]?[0-9]*\.?[0-9]+(?:[eE][-+]?[0-9]+)?( *- *[-+]?[0-9]*\.?[0-9]+(?:[eE][-+]?[0-9]+)?)?
*([^\s-]{1,2}|[^\s-]+.+[^\s-]+)$
structured_pattern:
syntax: ^{scientific_float}( *- *{scientific_float})? *{text}$
interpolated: true
partial_match: true
tot_nitro_cont_meth:
description: Reference or method used in determining the total nitrogen
title: total nitrogen content method
Expand Down Expand Up @@ -19124,7 +19101,8 @@ classes:
- nitrate
- nitrite
- ammonium
- tot_nitro
- tot_nitro_content
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tot_nitro_content is defined as “Total nitrogen content of the sample” (mass per mass examples), whereas the removed tot_nitro term was explicitly a concentration term (mass per volume) with water-oriented preferred units. Swapping tot_nitro → tot_nitro_content in this extension changes the semantics/expected units; consider instead generalizing tot_nitro’s description (removing the water-specific wording) or introducing a new generalized concentration term rather than reusing a “content” slot.

Suggested change
- tot_nitro_content
- tot_nitro

Copilot uses AI. Check for mistakes.
- tot_nitro_cont_meth
- diss_iron
- sodium
- chloride
Expand Down Expand Up @@ -19252,7 +19230,8 @@ classes:
- nitrate
- nitrite
- ammonium
- tot_nitro
- tot_nitro_content
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tot_nitro_content is a “content” slot (not a concentration slot), so replacing tot_nitro with tot_nitro_content here may change the intended measurement units/meaning for this extension. If the goal is only to remove water-specific wording, consider updating/retaining the concentration slot (MIXS:0000102) as deprecated/renamed rather than switching to tot_nitro_content.

Suggested change
- tot_nitro_content
- tot_nitro

Copilot uses AI. Check for mistakes.
- tot_nitro_cont_meth
- diss_iron
- sodium
- chloride
Expand Down Expand Up @@ -19385,6 +19364,7 @@ classes:
- temp
- tot_carb
- tot_nitro_content
- tot_nitro_cont_meth
- tot_org_carb
Comment on lines 19364 to 19368
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description lists updates for HydrocarbonResources* / Water / WastewaterSludge, but this diff also adds tot_nitro_cont_meth to the MicrobialMatBiofilm extension. Please either update the PR description/scope to include this extension or revert this additional change if it’s unintended.

Copilot uses AI. Check for mistakes.
- turbidity
- water_content
Expand Down Expand Up @@ -19742,6 +19722,7 @@ classes:
- tot_carb
- tot_depth_water_col
- tot_nitro_content
- tot_nitro_cont_meth
- tot_org_carb
- turbidity
- water_content
Expand Down Expand Up @@ -20076,7 +20057,8 @@ classes:
- suspend_solids
- temp
- tertiary_treatment
- tot_nitro
- tot_nitro_content
- tot_nitro_cont_meth
Comment on lines +20060 to +20061
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tot_nitro (removed) was a concentration term for water samples, while tot_nitro_content is defined as a sample “content” term. Replacing it in WastewaterSludge likely changes semantics/expected units; consider keeping a concentration-oriented slot (or adding a new generalized one) instead of mapping to the “content” slot.

Suggested change
- tot_nitro_content
- tot_nitro_cont_meth
- tot_nitro
- tot_nitro_meth

Copilot uses AI. Check for mistakes.
- tot_phosphate
- wastewater_type
slot_usage:
Expand Down Expand Up @@ -20183,7 +20165,8 @@ classes:
- tot_depth_water_col
- tot_diss_nitro
- tot_inorg_nitro
- tot_nitro
- tot_nitro_content
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Water extension, replacing tot_nitro (concentration) with tot_nitro_content (content) changes the meaning of the field and likely the expected units. If the intent is to make total nitrogen applicable beyond water, consider generalizing the existing concentration slot (MIXS:0000102) and deprecating/aliasing names, rather than switching to a different “content” slot.

Suggested change
- tot_nitro_content
- tot_nitro

Copilot uses AI. Check for mistakes.
- tot_nitro_cont_meth
- tot_part_carb
- tot_phosp
- turbidity
Expand Down
Loading