Update how nested perspectives are setup for collections #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nested Collections with namespaced models were receiving very odd defaults for the `as` option. For instance,a nested collection for instances of SomeModule::Group was creating a Collection with `:somemodule::group` as the `as` option. This makes defining a perspective that leverages the default `as` param rather cumbersome. Additionally, because of the call to base_class in the calculation of the default for `as`, it was impossible to define a nested collection for a PORO with an associated persepctive. I updated the calculation of the default to demodulize class names and to only call base_class when it is available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested Collections with namespaced models were receiving very odd defaults for the
asoption. For instance,a nested collection for instances of SomeModule::Group was creating a Collection with:somemodule::groupas theasoption. This makes defining a perspective that leverages the defaultasparam rather cumbersome. Additionally, because of the call to base_class in the calculation of the default foras, it was impossible to define a nested collection for a PORO with an associated persepctive. I updated the calculation of the default to demodulize class names and to only call base_class when it is available.This possibly fixes #3