Skip to content

Figure 3: Remove the sharex/sharey settings#34

Open
seisman wants to merge 2 commits intomainfrom
Fig3/sharexy
Open

Figure 3: Remove the sharex/sharey settings#34
seisman wants to merge 2 commits intomainfrom
Fig3/sharexy

Conversation

@seisman
Copy link
Member

@seisman seisman commented Feb 10, 2026

In this PR, I've removed sharex="b", sharey="l" settings from Figure 3. The main reasons are:

Old New
image Fig3_PyGMT_backgrounds

@yvonnefroehlich What do you think?

@gitnotebooks
Copy link

gitnotebooks bot commented Feb 10, 2026

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/GenericMappingTools/pygmt-paper-figures/pull/34

@seisman seisman marked this pull request as ready for review February 10, 2026 08:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Figure 3 PyGMT example notebook to stop sharing subplot axes, improving the readability of axis annotations (notably for the 3-D perspective panel) and simplifying the subplot configuration.

Changes:

  • Removed sharex="b" and sharey="l" from the fig.subplot(...) call so each panel manages its own axis annotations.
  • Adjusted subplot margins to accommodate the updated framing/annotations.
  • Notebook metadata was updated (Python version string).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yvonnefroehlich
Copy link
Member

Actually, I was thinking a bit about the frame annotations of the 3-D plot when initially creating this figure. It's nice that shared axes are supported by PyGMT, but I agree it looks not optimal here. Maybe we should focus on the base maps here and show frame annotations for all maps frame annotations. But I am currently unsure what is better. What do the others think @michaelgrund, @weiji14?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants