feat: Add Excel to PDF tools (analyze and execute)#34
Merged
Conversation
- Add ExcelPlaceholder, ExcelToPdfAnalyzeResponse, ExcelToPdfExecuteResponse models - Add excel_to_pdf_analyze and excel_to_pdf_execute methods to ToolsClient - Add Excel to PDF MCP tools to server.py - Add Excel to PDF CLI commands to main.py - Add comprehensive unit tests for Excel to PDF tools Co-Authored-By: yutaka.omido@generative-agents.co.jp <yutaka.omido@generative-agents.co.jp>
Contributor
Author
Original prompt from yutaka.omido@generative-agents.co.jp |
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
- Change endpoint URLs from excel-to-pdf-* to xlsx-to-pdf-* - Change parameter name from excel_template_id to xlsx_template_id - Update client.py, cli/main.py, mcp/server.py, and tests Co-Authored-By: yutaka.omido@generative-agents.co.jp <yutaka.omido@generative-agents.co.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Add Excel to PDF tools (analyze and execute)
Summary
This PR adds SDK support for the two new Excel to PDF tools introduced in middleman PR #627:
Changes include:
ExcelPlaceholder,ExcelToPdfAnalyzeResponse,ExcelToPdfExecuteResponseToolsClientmethods:excel_to_pdf_analyze(),excel_to_pdf_execute()excel-to-pdf-analyze,excel-to-pdf-executeUpdates since last revision
excel-to-pdf-*toxlsx-to-pdf-*to match the actual middleman APIexcel_template_idtoxlsx_template_idto match the API specificationxlsx_template_idscrubbing for VCR cassettesReview & Testing Checklist for Human
ExcelPlaceholder.descriptionfield is required in the SDK but hasdefault=""in the API - verify this doesn't cause validation errors when the API omits the fieldexcel-to-pdf-executeCLI reads placeholders JSON from stdin. Verify this works correctly:echo '{"name": "test"}' | middleman excel-to-pdf-execute <xlsx_template_id>test_excel_to_pdf_analyze_vcr.yaml,test_excel_to_pdf_execute_vcr.yaml)Recommended Test Plan
middleman excel-to-pdf-analyze <xlsx_template_id>and verify placeholder info is returnedecho '{"placeholder_key": "value"}' | middleman excel-to-pdf-execute <xlsx_template_id>and verify PDF is generatedNotes