Skip to content

Conversation

@spokonya
Copy link

@spokonya spokonya commented Jan 27, 2026

Description

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (code improvement without changing functionality)
  • Documentation update
  • Configuration/infrastructure change
  • Performance improvement
  • Test coverage improvement

Related Issue(s)

Related to #51

What Changed?

  • Added S3 configuration (config/s3.go) with environment variable support for AWS credentials, region, and bucket name
    -Added S3 test handler
  • Integrated S3 storage into app initialization and route setup (server.go)
  • Made an s3 storage layer that initializes S3 client with credentials, generates time-limited upload URLs for direct client-to-S3 uploads, and allows for server-side file deletion from S3

Testing & Validation

How this was tested

  1. started local server with s3 credentials configured
  2. Created a call for a presigned URL
  3. Used curl -X PUT with the presigned URL to upload a test file directly to s3
  4. verified file appeared in my s3 dashboard

Screenshots/Recordings

Unfinished Work & Known Issues

  • None, this PR is complete and production-ready
  • The following items are intentionally deferred:
    • user profile picture endpoints
    • Frontend UI for uploads

Notes & Nuances



Pre-Merge Checklist

Code Quality

  • Code follows the project's style guidelines and conventions
  • Self-review completed (I've reviewed my own code for obvious issues)
  • No debugging code, console logs, or commented-out code left behind
  • No merge conflicts with the base branch
  • Meaningful commit messages that explain the "why"

Testing & CI

  • All CI checks are passing
  • All new and existing tests pass locally
  • Test coverage hasn't decreased (or decrease is justified)
  • Linting passes without errors

Documentation

  • Code is self-documenting or includes helpful comments for complex logic
  • API documentation updated (if backend endpoints changed)
  • Type definitions are accurate and up-to-date

Reviewer Notes

  • Areas needing extra attention: ...
  • Questions for reviewers: I need help with my .env variables. When I was testing I connected to local supabase but I couldn't get connecting to the remote server. It was either telling me that I was missing a required value (which I had) or that "Tenant or user not found"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants