GET endpoint for usersID #59
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dao-Ho
requested changes
Jan 23, 2026
backend/internal/handler/users.go
Outdated
|
|
||
| } | ||
|
|
||
| func NewUserHandler(repo UsersRepository) *UsersHandler { |
backend/internal/repository/devs.go
Outdated
|
|
||
| return devs, nil | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Can we remove this? Or mv it to a separate pr? It's not related to get users
Author
There was a problem hiding this comment.
mb this was totally from the bootcamp exercise and I never got rid of it
spokonya
commented
Jan 26, 2026
Author
spokonya
left a comment
spokonya
left a comment
There was a problem hiding this comment.
Addressed comments:
- removed devs stuff
- Made NewUsersHandler plural
- Fixed naming convention for searching for a user at the db/repository level with "Find" instead of "Get"
Dao-Ho
requested changes
Jan 27, 2026
| type UsersRepository interface { | ||
|
|
||
| GetUserById(ctx context.Context, id string) (*models.User, error) | ||
| FindUserById(ctx context.Context, id string) (*models.User, error) |
Contributor
There was a problem hiding this comment.
For naming conventions, it's implied that FindT is FindTByid. One of the gotchas in naming that I forgot to mention, if its named findUser, it's implied that the param is the primary key/id unless otherwise stated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stuff added:
Closes #45