feat: add text input component with tests and stories by Kuba3330 · Pull Request #25 · Generacja-Innowacja/athena

Kuba3330 · 2026-02-23T16:46:51Z

Changes

What has been done in this PR?

Lefticon->lefticon
deleted comments in Textinput
changed theme background
changed errortext into helper

How to test

Describe how to test the changes manually

yarn storybook
...
...

Checklist

Check if the code follows the standards

Follows front-end standards
No unused code / console.log / leftover comments
Component is exported in the main.ts file (if applicable)
Resolved merge conflicts (if applicable)
Added / updated unit tests (if applicable)
Added / updated storybook stories (if applicable)

Co-authored-by: Cursor <cursoragent@cursor.com>

prewendowski · 2026-02-24T02:00:14Z

Why did you leave the template of PR almost blank? No changes, no testing description... Actually, you didn't write anything. We defined such a format, not github. We expect you to fill it.

whit33y

Few bugs that I found right now. I will do further more accurate review later.

src/components/ui/TextInput/TextInput.stories.tsx

src/components/ui/TextInput/TextInput.tsx

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

whit33y

You resolved bugs, but there is still place for improvement.
Just take a look at figma and styles.

https://www.figma.com/design/yZHdiIjMNUNJGyj9OLUpsz/athena?node-id=145-259&t=En2zw1gUl3BH3Uwj-4

ddebixx · 2026-02-25T12:51:36Z

src/components/ui/input.tsx

+
+function Input({ className, type, ...props }: React.ComponentProps<"input">) {
+  return (
+    <input


suggestion: I don't think that the input.tsx is needed, the idea was to improve it. So I think it should be deleted becuase we have TextInput component right now

ddebixx

Couple of changes needed

ddebixx · 2026-02-25T12:54:07Z

src/components/ui/TextInput/TextInput.tsx

+          <span className="text-sm text-muted-foreground">{prefix}</span>
+        )}
+
+        <Input


suggestion: I think this should look like this:

<input
id={inputId}
type={type}
value={value}
onChange={handleChange}
placeholder={placeholder}
required={required}
disabled={disabled}
data-test-id={dataTestId}
aria-invalid={isError || undefined}
className={cn("flex-1 border-0 bg-transparent px-0 py-0", className)}
{...inputProps}
/>

Instead of importing the basic version of shadcn input this component supposed to it's impoved version

src/components/ui/TextInput/TextInput.tsx

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

src/components/ui/TextInput/Input.tsx

ddebixx · 2026-02-25T16:16:37Z

src/components/ui/TextInput/Input.tsx

+  const generatedId = React.useId();
+  const inputId = id ?? generatedId;
+
+  const showError = Boolean(isError && errorText);


suggestion:

showError uses Boolean(isError && errorText) but aria-invalid ( line ) uses isError directly.
You can end up with aria-invalid="true" but displaying helper text instead of an error, which is confusing for assistive tech. It would be better to stick with one solution

ddebixx · 2026-02-25T16:17:44Z

src/components/ui/TextInput/Input.tsx

+  const required = isRequired ?? inputProps.required;
+
+  const handleChange = (event: React.ChangeEvent<HTMLInputElement>) => {
+    if (disabled) return;


suggestion:
handleChange early-returns when disabled is true. This is correct behavior, but because the input itself is already disabled, the handler won’t fire anyway; the guard is redundant.

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

ddebixx · 2026-02-25T17:34:41Z

src/components/ui/TextInput/Input.tsx

  const showError = isError;
-  const disabled = isDisabled ?? inputProps.disabled;
-  const required = isRequired ?? inputProps.required;
+  const disabled = isDisabled 


suggestion:

I don't think it's necessary to assign value of isDisabled and isRequired props to consts they can be passed straight were they should be used

suggestion:

try to provide more information in your commits names for example what has been changed, was it a feature, was it a fix.

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

github-actions · 2026-02-25T21:19:22Z

Coverage Report

Coverage after merging update-name into main will be:

	Hit/ Total	Coverage
🟰 Statements	`20 / 20`	100% 🥳
🌿 Branches	`35 / 36`	97.22% 🥳
🔢 Functions	`9 / 9`	100% 🥳
📝 Elements	`64 / 65`	98.46% 🥳

feat: add text input component with tests and stories

32e9edf

Co-authored-by: Cursor <cursoragent@cursor.com>

prewendowski linked an issue Feb 24, 2026 that may be closed by this pull request

Input #9

Open

whit33y requested changes Feb 24, 2026

View reviewed changes

Kuba3330 added 6 commits February 24, 2026 14:53

Update TextInput.stories.tsx

4c8dd61

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update TextInput.tsx

58872b8

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update TextInput.tsx

184eefa

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update TextInput.tsx

e457aa4

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update TextInput.tsx

2237df6

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update TextInput.tsx

7d7e47a

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Kuba3330 requested a review from whit33y February 25, 2026 09:13

Kuba3330 added 13 commits February 25, 2026 10:36

Update TextInput.tsx

54e6582

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update TextInput.tsx

e064011

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update TextInput.tsx

0088e66

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update TextInput.tsx

05ffe03

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update TextInput.tsx

a98ede7

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update TextInput.tsx

42cbffe

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update TextInput.tsx

c039391

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update TextInput.tsx

a78b61d

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update TextInput.tsx

efe0bfc

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update TextInput.tsx

68fa105

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update TextInput.tsx

2f8e2af

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update TextInput.tsx

17c5e6a

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update TextInput.tsx

9b8d132

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

whit33y requested changes Feb 25, 2026

View reviewed changes

ddebixx reviewed Feb 25, 2026

View reviewed changes

ddebixx requested changes Feb 25, 2026

View reviewed changes

Kuba3330 added 3 commits February 25, 2026 14:14

Update TextInput.tsx

60211b2

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update TextInput.test.tsx

f47ab1c

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Delete src/components/ui/input.tsx

41649b2

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Kuba3330 added 12 commits February 25, 2026 14:39

Update and rename TextInput.tsx to Input.tsx

6787537

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update TextInput.stories.tsx

d9107b3

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update TextInput.test.tsx

2c61e99

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update main.ts

fe6aabe

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update main.ts

18e74da

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update main.ts

964fa70

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update main.ts

feaa2f2

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update main.ts

eab7628

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update main.ts

abb560e

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update main.ts

0d303ef

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update Input.tsx

059e4d8

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update TextInput.test.tsx

1f14087

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

ddebixx requested changes Feb 25, 2026

View reviewed changes

Kuba3330 added 3 commits February 25, 2026 17:24

Update Input.tsx

cc30f3c

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update Input.tsx

4c36725

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update Input.tsx

419b90a

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

ddebixx requested changes Feb 25, 2026

View reviewed changes

Kuba3330 added 3 commits February 25, 2026 22:10

Update Input.tsx

d09d961

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update Input.tsx

f0f6073

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Update Input.tsx

ff17210

Signed-off-by: kuba kesler <keslerkuba12@gmail.com>

Conversation

Kuba3330 commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

How to test

Checklist

Uh oh!

prewendowski commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

whit33y left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

whit33y left a comment

Choose a reason for hiding this comment

Uh oh!

ddebixx Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ddebixx left a comment

Choose a reason for hiding this comment

Uh oh!

ddebixx Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 25, 2026

Coverage Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Kuba3330 commented Feb 23, 2026 •

edited

Loading

prewendowski commented Feb 24, 2026 •

edited

Loading

ddebixx Feb 25, 2026 •

edited

Loading

ddebixx Feb 25, 2026 •

edited

Loading