feat: Button update - icon handling, loading and danger states#24
Open
feat: Button update - icon handling, loading and danger states#24
Conversation
… z destructive na danger
prewendowski
previously requested changes
Feb 24, 2026
|
Please verify the checklist. By |
whit33y
previously requested changes
Feb 24, 2026
Contributor
whit33y
left a comment
There was a problem hiding this comment.
Two bugs that I found right now. I will do further more accurate review later.
The checklist was not followed, i.e. you marked as done something you didn't do. |
…rove props handling
…improve loading state rendering
Coverage ReportCoverage after merging
|
whit33y
reviewed
Feb 25, 2026
Contributor
whit33y
left a comment
There was a problem hiding this comment.
Changes that I requested are resolved and it looks good to me.
Great job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
What has been done in this PR?
-changing the destructive button to danger
-adding loading animation
How to test
Describe how to test the changes manually
Checklist
Check if the code follows the standards
console.log/ leftover comments