Skip to content

feat: Button update - icon handling, loading and danger states#24

Open
szaszuke wants to merge 6 commits intomainfrom
feature-button-update
Open

feat: Button update - icon handling, loading and danger states#24
szaszuke wants to merge 6 commits intomainfrom
feature-button-update

Conversation

@szaszuke
Copy link

@szaszuke szaszuke commented Feb 23, 2026

Changes

What has been done in this PR?

  • adding a right icon, left icon and crown icon
    -changing the destructive button to danger
    -adding loading animation

How to test

Describe how to test the changes manually

  • yarn storybook

Checklist

Check if the code follows the standards

  • Follows front-end standards
  • No unused code / console.log / leftover comments
  • Component is exported in the main.ts file (if applicable)
  • Resolved merge conflicts (if applicable)
  • Added / updated unit tests (if applicable)
  • Added / updated storybook stories (if applicable)

@szaszuke szaszuke changed the title poprawki (button) dodanie "lefticon" i "righticon" i dodanie korony do nich,zmiana destructive na danger i dodanie icony ladowania sie (button) Feb 23, 2026
@prewendowski
Copy link

Please verify the checklist. By [x] you can mark done items.

@prewendowski prewendowski changed the title (button) feat: Button update - icon handling, loading and danger states Feb 24, 2026
Copy link
Contributor

@whit33y whit33y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two bugs that I found right now. I will do further more accurate review later.

@prewendowski
Copy link

prewendowski commented Feb 24, 2026

Component is exported in the main.ts file (if applicable)

The checklist was not followed, i.e. you marked as done something you didn't do.

@github-actions
Copy link

Coverage Report

Coverage after merging feature-button-update into main will be:

Hit/ Total Coverage
🟰 Statements 19 / 19 100% 🥳
🌿 Branches 21 / 27 77.78% 😊
🔢 Functions 7 / 7 100% 🥳
📝 Elements 47 / 53 88.68% 🤩

Copy link
Contributor

@whit33y whit33y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes that I requested are resolved and it looks good to me.
Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants