Skip to content

fix(docker): add ffmpeg to viewer image for video thumbnails#172

Merged
GeiserX merged 1 commit into
mainfrom
fix/viewer-ffmpeg
May 25, 2026
Merged

fix(docker): add ffmpeg to viewer image for video thumbnails#172
GeiserX merged 1 commit into
mainfrom
fix/viewer-ffmpeg

Conversation

@GeiserX
Copy link
Copy Markdown
Owner

@GeiserX GeiserX commented May 24, 2026

Summary

  • Adds ffmpeg to Dockerfile.viewer so video thumbnail generation works in the viewer container
  • The backup container already had ffmpeg, but the viewer (which actually serves thumbnails) was missing it
  • All video thumb requests were returning 404 because _check_ffmpeg() returned False

Test plan

  • Verify viewer container has ffmpeg after rebuild
  • Verify video thumbnails generate on first request
  • Verify .MOV and .mp4 files show thumbnails in gallery

Summary by CodeRabbit

  • New Features
    • Video thumbnail extraction capability is now available.
  • Chores
    • Patch version update to 7.11.1.

Review Change Stack

The viewer container was missing ffmpeg, causing all video thumbnail
requests to return 404. Image thumbnails worked because Pillow was
present, but video extraction requires ffmpeg.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 660d4380-574a-4d2c-b2b3-3c7588c5c65e

📥 Commits

Reviewing files that changed from the base of the PR and between 3180d1c and 1d7145a.

📒 Files selected for processing (3)
  • Dockerfile.viewer
  • pyproject.toml
  • src/__init__.py

📝 Walkthrough

Walkthrough

PR adds ffmpeg system tooling to the viewer Dockerfile for video thumbnail extraction, and bumps package version from 7.11.0 to 7.11.1 across project metadata and package exports.

Changes

Video Thumbnail Support & Patch Release

Layer / File(s) Summary
ffmpeg system dependency for video thumbnails
Dockerfile.viewer
Docker image now includes ffmpeg in the system package installation to support video thumbnail extraction alongside existing Pillow-based image processing.
Version synchronization
pyproject.toml, src/__init__.py
Package version incremented from 7.11.0 to 7.11.1 across project metadata and package exports.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: adding ffmpeg to the viewer Docker image for video thumbnail support.
Description check ✅ Passed The description provides a clear summary of the fix with context on why it was needed and a reasonable test plan, though it doesn't fully match the repository's template structure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/viewer-ffmpeg

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.55%. Comparing base (3180d1c) to head (1d7145a).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #172   +/-   ##
=======================================
  Coverage   92.55%   92.55%           
=======================================
  Files          23       23           
  Lines        6599     6599           
=======================================
  Hits         6108     6108           
  Misses        491      491           
Files with missing lines Coverage Δ
src/__init__.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

🐳 Dev images published!

  • drumsergio/telegram-archive:dev
  • drumsergio/telegram-archive-viewer:dev

The dev/test instance will pick up these changes automatically (Portainer GitOps).

To test locally:

docker pull drumsergio/telegram-archive:dev
docker pull drumsergio/telegram-archive-viewer:dev

@GeiserX GeiserX merged commit 20e2ca3 into main May 25, 2026
10 checks passed
@GeiserX GeiserX deleted the fix/viewer-ffmpeg branch May 25, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant