Fix default BoolExpr accumulator construction#216
Open
zayenz wants to merge 2 commits into
Open
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #139 by making a default-constructed
BoolExprbehave as an empty accumulator during Boolean expression composition.A default
BoolExprnow acts as an identity for both&&and||composition, soempty && x,x && empty,empty || x, andx || emptyall collapse tox. This avoids choosing a global true/false meaning that would make one accumulator style silently wrong.Posting or materializing a still-empty
BoolExprnow fails explicitly withMiniModel::TooFewArguments("BoolExpr")instead of reading uninitialized node state.Validation
cmake -S . -B /tmp/gecode-bool-expr-build -DCMAKE_BUILD_TYPE=Debug -DGECODE_ENABLE_EXAMPLES=OFF -DGECODE_ENABLE_GIST=OFF -DGECODE_ENABLE_QT=OFFcmake --build /tmp/gecode-bool-expr-build --target gecode-test -j 8/tmp/gecode-bool-expr-build/bin/gecode-test -test MiniModel::BoolExpr::Default/tmp/gecode-bool-expr-build/bin/gecode-test -test MiniModel::BoolExpr./configure --disable-qt --disable-gist --disable-examples --disable-flatzinc --disable-float-vars --disable-set-vars --disable-mpfr,make -j4 test, andDYLD_LIBRARY_PATH=. ./test/test -test MiniModel::BoolExpr