Restore orchestration user opt-out gate#1
Open
nkoorty wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
OrchestrationV2and global AI were on, re-exposing StartAgent tooling and bypassing user consent.Description
orchestration_enabledsetting inAISettingswith TOML keyagents.warp_agent.other.orchestration_enabledandfeature_flag: FeatureFlag::OrchestrationV2so the persisted user preference is loaded again (app/src/settings/ai.rs).AISettings::is_orchestration_enabled()to require all three conditions:FeatureFlag::OrchestrationV2enabled, AI globally enabled, and*self.orchestration_enabled(user opt-in) (app/src/settings/ai.rs).orchestration_user_opt_out_disables_orchestration_even_when_v2_is_enabledand renamed the existing positive test to reflect both flag and user setting interaction (app/src/settings/ai_tests.rs).cargo fmt --all.Testing
cargo fmt --alland it completed successfully.app/src/settings/ai_tests.rs).cargo test -p warp orchestration_v2 --lib; a build was started but dependency compilation did not complete within this environment (long compile), so the full test run did not finish here.cargo testagainst-p appfailed because that package name does not exist in the workspace in this environment.Codex Task