Draft
Conversation
Key changes: - wallet now automatically takes tokens from investor on `addCollateral` calls - introduce `ON_DEMAND_LP` contract domain to abstract away the allowance logic - factory is now ownable, while registrars are added by instance owner - rename contracts
- more robust on-demand underlying logic - vault registration logic is moved from factory to degen NFT - add operators who can register additional helper accounts (e.g., for non-atomic withdrawals) - general code cleanup and unification
Can now attach to live DS tokens and registrars by passing proper env variables. Mock DS token and registrar now look closer to original contracts.
lekhovitsky
force-pushed
the
securitize-integration
branch
from
c56309d to
61c8684
Compare
- remove the version of `registerHelperAccount` that uses cached signature - return more data in `serialize` - more robust logic overall
In this PR: - `SecuritizeKYCFactory` now returns DS tokens in serialized state - additional fields in serialized state of `OnDemandKYCUnderlying` and `MonopolizedOnDemandLP` - update `MockVaultRegistrar` to reflect changes in VR behavior after audits
- subcompressors are now versioned - `KYCCompressor` is saved in address provider - important deployed addresses (configurator, factory) are saved in `kyc-addresses.json`
…an attach to real DS tokens
No idea why it worked before though.
* chore: notfify anvil-manager about new MC and KYC factory * chore: update actions, pnpm safety, docker tags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.