Skip to content

CAN Peripheral Abstraction #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
VihanJ merged 19 commits into from
Jan 16, 2026
Merged

CAN Peripheral Abstraction #183

VihanJ merged 19 commits into from
Jan 16, 2026

Conversation

@VihanJ
Copy link
Contributor

@VihanJ VihanJ commented Jan 16, 2026

CAN Peripheral API

Problem and Scope

Description

  • the electrical team won't be mad at us!

Gotchas and Limitations

Testing

  • HOOTL testing
  • HITL testing
  • Human tested

Testing Details

Larger Impact

Additional Context and Ticket

VihanJ and others added 13 commits January 7, 2026 04:18
@VihanJ
Structure for STM32G4, can_init mostly done
ac1ca1f
@VihanJ
finished all minimal functions, now need to write HITL tests
1d846ef
@VihanJ
need to figure out cmake
b4fc608
@VihanJ
compiles
8061048
@VihanJ
RX callback is entered after sending TX message, using internal CAN l…
1811a54 
…oopback
@dchansen06
Setup G4PERTESTING to have successful LOGOMATIC operations
6ed53d0
@dchansen06
Add `canCfg.hal_fdcan_init.TxFifoQueueMode = FDCAN_TX_FIFO_OPERATION;…
97afbc0 
…` to `can_tests.c`
@VihanJ
FDCAN on PCLK1
984649a
@VihanJ
single node success
b62eb92
@VihanJ
Filter confirmed to work, need LOGOMATIC
fe669d2
@dchansen06
Ensure still 1 Mbps can nominal baud rate and such while supporting `…
aeb1f05 
…LOGOMATIC`
@dchansen06
Copy G4PERTESTING to G4CANTESTING and undo G4PERTESTING changes to ho…
6161349 
…pefully make life easier for merge conflicts and continued dev of peripherals in parallel but incremental fixes
@VihanJ
Jan 19th ready, 1000%
a169063
@VihanJ VihanJ requested a review from dchansen06 as a code owner January 16, 2026 06:40
@dchansen06 dchansen06 added Enhancement New feature or request CMake Anything related to or dealing with CMake 1 URGENT Urgent issue that needs a quick action and resolution Big Fry Something that is complex and/or large Peripheral Related to or involving a peripheral including abstractions labels Jan 16, 2026
@dchansen06 dchansen06 linked an issue Jan 16, 2026 that may be closed by this pull request
CAN Peripheral Abstractions #31
Closed
github-actions bot and others added 3 commits January 16, 2026 06:49
@github-actions
Automatic Clang-Format: Standardized formatting automatically
ff7514b
@ahoysal @dchansen06
@nacsoprog @VihanJ
fixed all warnings
6ae7fa2 
Co-authored-by: Daniel Hansen <dchansen06@users.noreply.github.com>
Co-authored-by: Nathan So <nathansocollege@gmail.com>
Co-authored-by: ShortSideburns <vjayaraman@ucsb.edu>
@github-actions
Automatic Clang-Format: Standardized formatting automatically
00a42c7
dchansen06
dchansen06 approved these changes Jan 16, 2026
View reviewed changes
Copy link
Contributor

@dchansen06 dchansen06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full send

@dchansen06 dchansen06 changed the title Can CAN Peripheral Abstraction Jan 16, 2026
@VihanJ VihanJ merged commit d6c1642 into main Jan 16, 2026
26 checks passed
@VihanJ VihanJ deleted the CAN branch January 16, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dchansen06 dchansen06 dchansen06 approved these changes

Assignees

@ahoysal ahoysal

@VihanJ VihanJ

@nacsoprog nacsoprog

Labels

1 URGENT Urgent issue that needs a quick action and resolution Big Fry Something that is complex and/or large CMake Anything related to or dealing with CMake Enhancement New feature or request Peripheral Related to or involving a peripheral including abstractions

Projects

None yet

Milestone

GR26 - Firmware Feature Freeze

Development

Successfully merging this pull request may close these issues.

CAN Peripheral Abstractions

4 participants

@VihanJ @dchansen06 @ahoysal @nacsoprog