Add EMA low-pass filter module #182
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Updated with rebase |
dchansen06
force-pushed
the
ema-filter
branch
from
ecd1128 to
c2871bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EMA Low-Pass Filter
Problem and Scope
The existing approach for smoothing, the windowed moving average, requires a window. This is intuitive and enforces a hard cutoff for old samples. However, it needs memory, which may be less performant. I also noticed some integer division which could cause awkward truncation behavior, and the DMA is still configured as NOINCREMENT.
Hence, I added an EMA approach to smoothing in the ADC code.