fix: run build before package/make/publish to prevent stale bundles#39
Open
crtahlin wants to merge 1 commit into
Open
fix: run build before package/make/publish to prevent stale bundles#39crtahlin wants to merge 1 commit into
crtahlin wants to merge 1 commit into
Conversation
package, make, and publish scripts now run `npm run build` first. Previously they only ran electron-forge directly, which would bundle whatever was in dist/ — potentially stale UI code from an earlier build. Also documents the macOS .app copy gotcha in CLAUDE.md. AI-assisted implementation.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package,make, andpublishscripts now runnpm run buildfirstelectron-forgedirectly, which bundled whatever was indist/— potentially stale UI code from an earlier build.appcopy gotcha in CLAUDE.mdChanged files
package.jsonnpm run build &&to package/make/publish scriptsCLAUDE.mdrm -rfbeforecp -RAI-assisted implementation.