feat(embed): add embedding job drain#1
Closed
GaosCode wants to merge 1 commit intofeat/embedding-providersfrom
Closed
feat(embed): add embedding job drain#1GaosCode wants to merge 1 commit intofeat/embedding-providersfrom
GaosCode wants to merge 1 commit intofeat/embedding-providersfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is logically stacked on steipete#32, but it targets
mainbecause this is a fork-based contribution.It adds the storage and execution layer for queued message embeddings.
sync --with-embeddingsqueues embedding work without calling the provider, and the newdiscrawl embedcommand explicitly drains pending jobs in bounded batches.Until steipete#32 lands, this PR will also show the provider abstraction diff from that PR. Please review steipete#32 first. After steipete#32 is merged, this PR should collapse to the embedding job drain changes only. If the upstream merge strategy prevents that, I will rebase this branch.
Changes
message_embeddingsstorage keyed by message, provider, model, and input version.embedding_jobswith provider/model/input version, error tracking, and lock metadata.discrawl embedwith--limit,--batch-size, and--rebuild.sync --with-embeddingsnon-blocking by only queueing work.Testing
go test ./...Added coverage for:
Risks / Notes
mainwhile depending on #<PR2_NUMBER>, the initial diff may be noisy until feat(embed): add local embedding providers steipete/discrawl#32 is merged.