Calling Bell: refactor to use advancements instead of scoreboard checks#1274
Open
runcows wants to merge 3 commits intoGamemode4Dev:update-26.1from
Open
Calling Bell: refactor to use advancements instead of scoreboard checks#1274runcows wants to merge 3 commits intoGamemode4Dev:update-26.1from
runcows wants to merge 3 commits intoGamemode4Dev:update-26.1from
Conversation
Bloo-dev
added
the
quality-update
Contributor
Author
|
This PR has had bolt added with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large refactor of Calling Bell.
No longer has any ticking functions, all logic is now only run on the event of a player ringing a bell with an emerald, via an advancement.
Raycast now also uses block interaction range.
Build will fail due to mecha throwing an error due to
time query day repetitionwhich is the new way of getting day number in the 26.1 snapshots. We can force the build by prefixing the line withrawand requiring bolt