Merged
Conversation
…apacks into lib_hooked_entity
Contributor
Author
|
I've been testing this with the help of InQuognito, who is the one that found the issue resolved with 94bd243 regarding the adventure mode fail still being present. |
…apacks into lib_hooked_entity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separates the logic Reeling Rods uses to select the hooked entity into its own library targetting the
update-26.1branch.Updates Reeling Rods to use this library.
Not entirely sure on the naming of this library, since it's a very specific scenario. I considered
lib_hooked_entity_selectionbut that is quite verbose.Also I noticed that the readme files of all the other libraries were using a broken link to the repo, so this also just fixes that while I'm here.
Tested in game with Reeling Rods. Works as expected.