feat: introduce standardized contract error codes and replace string …#528
Open
oyinade247 wants to merge 1 commit into
Open
feat: introduce standardized contract error codes and replace string …#528oyinade247 wants to merge 1 commit into
oyinade247 wants to merge 1 commit into
Conversation
…panics with structured error handling
|
@oyinade247 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #348
Pull Request: Centralize Contract Panics into Definitive Error Enum
Summary This PR implements a centralized error handling system for the Soroban contracts. By replacing generic
panic!()calls with a#[contracterror]enum, we enable frontend SDKs to receive specificu32error codes. This allows for precise error reporting and user-friendly tooltips (e.g., "Bounty Not Found" instead of a generic "Panic").Core Changes
contract/src/errors.rswith theErrorCodeenum.panic_with_error!:lib.rs: Initialization checks.bounty/mod.rs: Authorization, claim checks, and bounty lookups.treasury/management.rs: Balance checks, budget enforcement, and treasury lookups.contract/ERRORS.mdto mapu32codes to descriptions and recommended UI tooltips for frontend developers.contract/src/dummy.rsto demonstrate the standard implementation pattern.Mapped Error Codes
Testing Refactored logic maintains existing functional behavior while upgrading the revert mechanism to use native Soroban error codes. Verified that
panic_with_error!is correctly implemented across the target modules.