fix: token authority override #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, updateTokenClass() augments the existing authority list. The overrideAuthorities = true flag must be passed to remove an existing authority or authorities from the list. Fix updateTokenClass() call to behave as described in the preceeding comment. ref https://github.com/GalaChain/sdk/blob/b5a6db2ac8fbff6d29d5a7cec786e464e08a696a/chain-api/src/types/TokenClass.ts#L284-L286
sentientforest
added a commit
to sentientforest/galachain-sdk
that referenced
this pull request
Dec 18, 2025
Outdated comment describes `overrideAuthorities` boolean as not yet implemented, inspection of code shows it is in fact used: ref: https://github.com/GalaChain/sdk/blob/b5a6db2ac8fbff6d29d5a7cec786e464e08a696a/chain-api/src/types/TokenClass.ts#L284-L286 related: GalaChain/launchpad#45
Jehosephat
approved these changes
Dec 18, 2025
Jehosephat
added a commit
to GalaChain/sdk
that referenced
this pull request
Dec 18, 2025
Outdated comment describes `overrideAuthorities` boolean as not yet implemented, inspection of code shows it is in fact used: ref: https://github.com/GalaChain/sdk/blob/b5a6db2ac8fbff6d29d5a7cec786e464e08a696a/chain-api/src/types/TokenClass.ts#L284-L286 related: GalaChain/launchpad#45 Co-authored-by: Jehosephat <jeganhouse@gala.games>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, updateTokenClass() augments the existing authority list. The overrideAuthorities = true flag must be passed to remove an existing authority or authorities from the list.
Fix updateTokenClass() call to behave as described in the preceeding comment.
ref
https://github.com/GalaChain/sdk/blob/b5a6db2ac8fbff6d29d5a7cec786e464e08a696a/chain-api/src/types/TokenClass.ts#L284-L286