fix: clean up LCD offline message and add run-local Makefile target#99
Merged
Conversation
Closes #62: replace the hand-padded "Weather offline / ...retrying" lines with "Connecting... / Please wait" — no leading spaces, looks intentional rather than placeholder-y. Closes #66: add run-local target to test/Makefile.mac that sources .env before running (graceful no-op if .env is absent), matching what systemd does via EnvironmentFile on the Pi. README updated to use run-local as the standard Mac dev command. https://claude.ai/code/session_01VdFLjQPRxkWMY96TZBNHKp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"Weather offline" / " ...retrying"LCD lines with"Connecting..." / "Please wait". No hard-coded leading/trailing spaces.run-localtarget totest/Makefile.macthat sources.envbefore running (graceful no-op if.envabsent). README updated to recommendrun-localas the standard Mac dev command.Changes
src/display_rotation.cpp— offline fallback strings updatedtest/Makefile.mac— newrun-localtarget;.PHONYupdatedREADME.md— Mac dev section now showsmake -f test/Makefile.mac run-localas the primary commandTest plan
src/display_rotation.cppno longer has leading-space padding in the offline branchmake -f test/Makefile.mac run-localwith.envpresent — verify env vars loadmake -f test/Makefile.mac run-localwith.envabsent — verify it starts without errormake -f test/Makefile.mac run— verify plain run still works