Fix CRLF header injection in SMTP From and To headers#103
Merged
Conversation
gmailUser_ and recipient_ were written into the From: and To: header lines without sanitization, leaving the same CRLF-injection vector that the original PR fixed for Subject. Apply stripCRLF() to both fields so all three header values are injection-safe. https://claude.ai/code/session_01Lq2gNbRv9voqav7jsmQMnD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #70
The
Subject:header was already sanitized viastripCRLF(), butFrom:andTo:were passinggmailUser_andrecipient_directly into the raw SMTP message without stripping. A malformed value in either field could inject arbitrary headers into outgoing mail.Changes
src/alerter.cpp: wrapgmailUser_andrecipient_withstripCRLF()when building theFrom:andTo:SMTP headersTest plan
.envconfigurationGMAIL_USERvalue containing\r\ndoes not produce extra headers in the outgoing message