update

.github/workflows/code-review.yml

@@ -0,0 +1,30 @@
+name: Code Review
+
+on: [pull_request]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - name: Use Node.js 10.x
+        uses: actions/setup-node@v1
+        with:
+          node-version: 10.x
+
+      - name: npm install
+        run: |
+          npm install --save-dev danger
+          npm install --save-dev @babel/plugin-transform-flow-strip-types
+          npm install --save-dev @babel/core
+        env:
+          CI: true
+
+      - name: Danger JS Action
+        uses: danger/danger-js@9.2.10
+        with:
+          args: "--dangerfile ./dangerfile.js"
+        env:
+          GITHUB_TOKEN: ${{ secrets.ACCESS_TOKEN }}

.github/workflows/danger-test.yml

@@ -1,7 +1,7 @@
 name: Danger-Test
 
 on:
-  push:
+  pull_request:
     branches:
       - master
       - develop
@@ -16,8 +16,12 @@ jobs:
     steps:
     - name: Checkout
       uses: actions/checkout@v2
-      
+
     - name: Danger JS Action
-      uses: ./scripts/run-danger/
+      uses: ./ #danger/danger-js@9.1.8
       env:
         GITHUB_TOKEN: ${{ secrets.ACCESS_TOKEN }}
+
+    # - name: Danger JS Action
+    #   uses: ./scripts/run-danger/
+

.github/workflows/swift.yml

@@ -15,7 +15,7 @@ jobs:
 
     steps:
     - uses: actions/checkout@v2
-    - uses: actions/setup-python@v1
+    - uses: actions/setup-python@v
       with:
         python-version: '3.7'
     - name: Run python for test

.gitignore

@@ -89,3 +89,4 @@ fastlane/test_output
 
 iOSInjectionProject/
 *.DS_Store
+__pycache__/

.swiftformat

@@ -0,0 +1,33 @@
+--allman false
+--binarygrouping none
+--closingparen balanced
+--commas always
+--conflictmarkers reject
+--decimalgrouping none
+--elseposition same-line
+--empty void
+--exponentcase lowercase
+--exponentgrouping disabled
+--fractiongrouping disabled
+--fragment false
+--header ignore
+--hexgrouping none
+--hexliteralcase uppercase
+--ifdef indent
+--importgrouping alphabetized
+--indent 4
+--indentcase false
+--linebreaks lf
+--octalgrouping none
+--operatorfunc spaced
+--patternlet hoist
+--ranges spaced
+--self insert
+--selfrequired 
+--semicolons never
+--stripunusedargs closure-only
+--trailingclosures 
+--trimwhitespace always
+--wraparguments preserve
+--wrapcollections preserve
+--xcodeindentation disabled

Configuration/Debug/Debug.xcconfig

@@ -15,3 +15,6 @@ BundleIdentifier = cn.com.hsbcchina.tech.test
 BundleShortVersion = 1.0.0
 
 APIDomain = www.baidu.com
+
+PRODUCT_NAME = $(inherited) α
+

Configuration/Release/Release.xcconfig

@@ -15,3 +15,5 @@ BundleIdentifier = cn.com.hsbcchina.tech
 BundleShortVersion = 2.30.0
 
 APIDomain = www.baidu.com
+
+PRODUCT_NAME = $(inherited) α

Dockerfile

@@ -0,0 +1,8 @@
+FROM node:12
+
+RUN npm install --save-dev @babel/plugin-transform-flow-strip-types
+RUN npm install --save-dev @babel/core 
+RUN npm install --save-dev danger
+
+ADD entrypoint.sh /entrypoint.sh
+ENTRYPOINT ["/entrypoint.sh"]

X3.xcodeproj/project.pbxproj

@@ -171,10 +171,10 @@
 			isa = PBXNativeTarget;
 			buildConfigurationList = 1BA42C2C23F41CBF0073A423 /* Build configuration list for PBXNativeTarget "X3" */;
 			buildPhases = (
+				1BA42CEF23F45DC70073A423 /* ShellScript */,
 				1BA42BFE23F41CBC0073A423 /* Sources */,
 				1BA42BFF23F41CBC0073A423 /* Frameworks */,
 				1BA42C0023F41CBC0073A423 /* Resources */,
-				1BA42CEF23F45DC70073A423 /* ShellScript */,
 			);
 			buildRules = (
 			);
@@ -309,7 +309,7 @@
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 			shellPath = /bin/sh;
-			shellScript = "# Type a script or drag a script file from your workspace to insert its path.\n./scripts/run-scripts.sh\n";
+			shellScript = "# Type a script or drag a script file from your workspace to insert its path.\n./scripts/run-scripts.sh\n\ncd BuildTools\nswift run -c release swiftformat \"$SRCROOT\"\n";
 			showEnvVarsInLog = 0;
 		};
 /* End PBXShellScriptBuildPhase section */
@@ -491,7 +491,7 @@
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				CODE_SIGN_IDENTITY = "Apple Development: taoli zheng (KNPJFG8XBK)";
 				CODE_SIGN_STYLE = Manual;
-				CURRENT_PROJECT_VERSION = "";
+				CURRENT_PROJECT_VERSION = 20200222121535;
 				DEVELOPMENT_ASSET_PATHS = "\"X3/Preview Content\"";
 				DEVELOPMENT_TEAM = 3P8FAFCTA3;
 				ENABLE_PREVIEWS = YES;
@@ -506,6 +506,7 @@
 				PROVISIONING_PROFILE_SPECIFIER = x3;
 				SWIFT_VERSION = 5.0;
 				TARGETED_DEVICE_FAMILY = 1;
+				VERSIONING_SYSTEM = "apple-generic";
 			};
 			name = Debug;
 		};
@@ -516,7 +517,7 @@
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				CODE_SIGN_IDENTITY = "Apple Development: taoli zheng (KNPJFG8XBK)";
 				CODE_SIGN_STYLE = Manual;
-				CURRENT_PROJECT_VERSION = "";
+				CURRENT_PROJECT_VERSION = 20200222121535;
 				DEVELOPMENT_ASSET_PATHS = "\"X3/Preview Content\"";
 				DEVELOPMENT_TEAM = 3P8FAFCTA3;
 				ENABLE_PREVIEWS = YES;
@@ -531,6 +532,7 @@
 				PROVISIONING_PROFILE_SPECIFIER = x3;
 				SWIFT_VERSION = 5.0;
 				TARGETED_DEVICE_FAMILY = 1;
+				VERSIONING_SYSTEM = "apple-generic";
 			};
 			name = Release;
 		};

X3.xcodeproj/xcshareddata/xcschemes/X3.xcscheme

@@ -0,0 +1,98 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<Scheme
+   LastUpgradeVersion = "1130"
+   version = "1.3">
+   <BuildAction
+      parallelizeBuildables = "YES"
+      buildImplicitDependencies = "YES">
+      <BuildActionEntries>
+         <BuildActionEntry
+            buildForTesting = "YES"
+            buildForRunning = "YES"
+            buildForProfiling = "YES"
+            buildForArchiving = "YES"
+            buildForAnalyzing = "YES">
+            <BuildableReference
+               BuildableIdentifier = "primary"
+               BlueprintIdentifier = "1BA42C0123F41CBC0073A423"
+               BuildableName = "&#x6c47;&#x4e30;&#x79d1;&#x6280;.app"
+               BlueprintName = "X3"
+               ReferencedContainer = "container:X3.xcodeproj">
+            </BuildableReference>
+         </BuildActionEntry>
+      </BuildActionEntries>
+   </BuildAction>
+   <TestAction
+      buildConfiguration = "Debug"
+      selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
+      selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
+      shouldUseLaunchSchemeArgsEnv = "YES">
+      <Testables>
+         <TestableReference
+            skipped = "NO">
+            <BuildableReference
+               BuildableIdentifier = "primary"
+               BlueprintIdentifier = "1BA42C1723F41CBF0073A423"
+               BuildableName = "X3Tests.xctest"
+               BlueprintName = "X3Tests"
+               ReferencedContainer = "container:X3.xcodeproj">
+            </BuildableReference>
+         </TestableReference>
+         <TestableReference
+            skipped = "NO">
+            <BuildableReference
+               BuildableIdentifier = "primary"
+               BlueprintIdentifier = "1BA42C2223F41CBF0073A423"
+               BuildableName = "X3UITests.xctest"
+               BlueprintName = "X3UITests"
+               ReferencedContainer = "container:X3.xcodeproj">
+            </BuildableReference>
+         </TestableReference>
+      </Testables>
+   </TestAction>
+   <LaunchAction
+      buildConfiguration = "Debug"
+      selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
+      selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
+      launchStyle = "0"
+      useCustomWorkingDirectory = "NO"
+      ignoresPersistentStateOnLaunch = "NO"
+      debugDocumentVersioning = "YES"
+      debugServiceExtension = "internal"
+      allowLocationSimulation = "YES">
+      <BuildableProductRunnable
+         runnableDebuggingMode = "0">
+         <BuildableReference
+            BuildableIdentifier = "primary"
+            BlueprintIdentifier = "1BA42C0123F41CBC0073A423"
+            BuildableName = "&#x6c47;&#x4e30;&#x79d1;&#x6280;.app"
+            BlueprintName = "X3"
+            ReferencedContainer = "container:X3.xcodeproj">
+         </BuildableReference>
+      </BuildableProductRunnable>
+   </LaunchAction>
+   <ProfileAction
+      buildConfiguration = "Release"
+      shouldUseLaunchSchemeArgsEnv = "YES"
+      savedToolIdentifier = ""
+      useCustomWorkingDirectory = "NO"
+      debugDocumentVersioning = "YES">
+      <BuildableProductRunnable
+         runnableDebuggingMode = "0">
+         <BuildableReference
+            BuildableIdentifier = "primary"
+            BlueprintIdentifier = "1BA42C0123F41CBC0073A423"
+            BuildableName = "&#x6c47;&#x4e30;&#x79d1;&#x6280;.app"
+            BlueprintName = "X3"
+            ReferencedContainer = "container:X3.xcodeproj">
+         </BuildableReference>
+      </BuildableProductRunnable>
+   </ProfileAction>
+   <AnalyzeAction
+      buildConfiguration = "Debug">
+   </AnalyzeAction>
+   <ArchiveAction
+      buildConfiguration = "Release"
+      revealArchiveInOrganizer = "YES">
+   </ArchiveAction>
+</Scheme>

X3/Info.plist

@@ -15,9 +15,9 @@
 	<key>CFBundlePackageType</key>
 	<string>$(PRODUCT_BUNDLE_PACKAGE_TYPE)</string>
 	<key>CFBundleShortVersionString</key>
-	<string>$(BundleShortVersion)</string>
+	<string>2.30.0</string>
 	<key>CFBundleVersion</key>
-	<string>20200214033412</string>
+	<string>20200222121535</string>
 	<key>LSRequiresIPhoneOS</key>
 	<true/>
 	<key>UIApplicationSceneManifest</key>

X3Tests/Info.plist

@@ -15,8 +15,8 @@
 	<key>CFBundlePackageType</key>
 	<string>$(PRODUCT_BUNDLE_PACKAGE_TYPE)</string>
 	<key>CFBundleShortVersionString</key>
-	<string>1.0</string>
+	<string>2.30.0</string>
 	<key>CFBundleVersion</key>
-	<string>1</string>
+	<string>20200222121535</string>
 </dict>
 </plist>

X3UITests/Info.plist

@@ -15,8 +15,8 @@
 	<key>CFBundlePackageType</key>
 	<string>$(PRODUCT_BUNDLE_PACKAGE_TYPE)</string>
 	<key>CFBundleShortVersionString</key>
-	<string>1.0</string>
+	<string>2.30.0</string>
 	<key>CFBundleVersion</key>
-	<string>1</string>
+	<string>20200222121535</string>
 </dict>
 </plist>

dangerfile.js

@@ -0,0 +1,12 @@
+import {message, warn, markdown, danger} from "danger"
+
+message("ha ha ha")
+
+danger.git.modified_files.length
+
+// Encourage smaller PRs
+var bigPRThreshold = 30;
+if (danger.github.pr.additions + danger.github.pr.deletions > bigPRThreshold) {
+  warn(':exclamation: Big PR (' + ++errorCount + ')');
+  markdown('> (' + errorCount + ') : Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.');
+}

entrypoint.sh

@@ -0,0 +1,6 @@
+#!/bin/sh -l
+
+echo $(which danger)
+
+# Run danger
+danger --dangerfile "./" ci

scripts/deprecated/check_tool.py

@@ -0,0 +1,8 @@
+# This script use to check whether the specify tool is installed.
+
+import os
+import subprocess
+
+def is_tool_installed(tool):
+    devnull = open(os.devnull, 'w')
+    return subprocess.run(['which', tool], stdout = devnull).returncode == 0

scripts/package.json

@@ -0,0 +1,5 @@
+{
+  "devDependencies": {
+    "danger": "^9.2.10"
+  }
+}

scripts/swiftformat.py

@@ -0,0 +1,7 @@
+import subprocess
+
+def swiftformat(file, config):
+    print("format " + file)
+    subprocess.run(["swiftformat", file, "--config", config])
+
+