Conversation
Owner
GabDug
commented
Jun 15, 2025
- Support Python 3.13
- Support PDM up-to 2.25
- Update dev tools
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
==========================================
- Coverage 92.22% 86.81% -5.41%
==========================================
Files 2 2
Lines 90 91 +1
Branches 16 15 -1
==========================================
- Hits 83 79 -4
- Misses 6 8 +2
- Partials 1 4 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project’s configuration, tests, and core functionality to support Python 3.13 and PDM 2.25 while modernizing development tools.
- Update tox.ini and pyproject.toml to support new Python/PDM versions and tooling.
- Add or update type hints and test functions in the tests files.
- Adjust core wheel export logic (including cleanup and candidate handling) and update configuration files (.mise.toml, .envrc, etc.) accordingly.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tox.ini | Updated environment matrix and dependency versions. |
| tests/test_wheel.py | Added type annotations and renamed one test function. |
| tests/test_clean.py | Added type annotations and updated file iteration. |
| tests/fixtures/pyproject.toml | Added Python 3.13 classifier. |
| tests/conftest.py | Updated type annotations and fixture signatures. |
| src/pdm_wheel/wheel.py | Revised import statements and improved cleanup/candidate handling logic. |
| pyproject.toml | Updated dev dependencies and tool configurations. |
| README.md | Updated supported versions and links. |
| .vscode/settings.json | Modified analyzer settings and formatter configuration. |
| .tool-versions, .envrc | Removed obsolete or unused configurations. |
| .pre-commit-config.yaml | Updated hook revisions and Python version for pre-commit. |
| .mise.toml | Added new configuration file for tool versions. |
Comments suppressed due to low confidence (2)
src/pdm_wheel/wheel.py:161
- Typo in the message: 'Using it them other platforms' should be corrected to 'Using it on other platforms'.
"Using it them other platforms may cause unexpected result.",
tests/test_wheel.py:105
- The docstring for 'test_export_with_clean' is outdated as it still references the help message; update it to accurately describe the test's purpose.
def test_export_with_clean(example_project: Project, invoke) -> None:
8707e5c to
2058ece
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.