Skip to content

chore: move mise, update to recent PDM, Python#15

Open
GabDug wants to merge 2 commits intomainfrom
pdm225
Open

chore: move mise, update to recent PDM, Python#15
GabDug wants to merge 2 commits intomainfrom
pdm225

Conversation

@GabDug
Copy link
Copy Markdown
Owner

@GabDug GabDug commented Jun 15, 2025

  • Support Python 3.13
  • Support PDM up-to 2.25
  • Update dev tools

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 15, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.81%. Comparing base (36ba504) to head (34649b0).

Files with missing lines Patch % Lines
src/pdm_wheel/wheel.py 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   92.22%   86.81%   -5.41%     
==========================================
  Files           2        2              
  Lines          90       91       +1     
  Branches       16       15       -1     
==========================================
- Hits           83       79       -4     
- Misses          6        8       +2     
- Partials        1        4       +3     
Flag Coverage Δ
unittests 86.81% <83.33%> (-13.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project’s configuration, tests, and core functionality to support Python 3.13 and PDM 2.25 while modernizing development tools.

  • Update tox.ini and pyproject.toml to support new Python/PDM versions and tooling.
  • Add or update type hints and test functions in the tests files.
  • Adjust core wheel export logic (including cleanup and candidate handling) and update configuration files (.mise.toml, .envrc, etc.) accordingly.

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tox.ini Updated environment matrix and dependency versions.
tests/test_wheel.py Added type annotations and renamed one test function.
tests/test_clean.py Added type annotations and updated file iteration.
tests/fixtures/pyproject.toml Added Python 3.13 classifier.
tests/conftest.py Updated type annotations and fixture signatures.
src/pdm_wheel/wheel.py Revised import statements and improved cleanup/candidate handling logic.
pyproject.toml Updated dev dependencies and tool configurations.
README.md Updated supported versions and links.
.vscode/settings.json Modified analyzer settings and formatter configuration.
.tool-versions, .envrc Removed obsolete or unused configurations.
.pre-commit-config.yaml Updated hook revisions and Python version for pre-commit.
.mise.toml Added new configuration file for tool versions.
Comments suppressed due to low confidence (2)

src/pdm_wheel/wheel.py:161

  • Typo in the message: 'Using it them other platforms' should be corrected to 'Using it on other platforms'.
            "Using it them other platforms may cause unexpected result.",

tests/test_wheel.py:105

  • The docstring for 'test_export_with_clean' is outdated as it still references the help message; update it to accurately describe the test's purpose.
def test_export_with_clean(example_project: Project, invoke) -> None:

@GabDug GabDug force-pushed the pdm225 branch 2 times, most recently from 8707e5c to 2058ece Compare June 15, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants