Remove TConstruct slot support from grave auto-equip when tab is disabled#50
Open
Eldrinn-Elantey wants to merge 2 commits into
Open
Remove TConstruct slot support from grave auto-equip when tab is disabled#50Eldrinn-Elantey wants to merge 2 commits into
Eldrinn-Elantey wants to merge 2 commits into
Conversation
|
Rather than completely removing this, could you just check for the config to disable the tinker tab? That way it will be useful in other modpacks that want to keep the tab. |
Eldrinn-Elantey
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #48 and GTNewHorizons/TinkersConstruct#279.
TConstruct slot handling is kept but skipped when
PHConstruct.enableTinkerInventoryTabis false. This prevents items from being silently placed into hidden non-functional slots when the tab is disabled, while still working correctly in modpacks that keep it enabled.