Skip to content

[Memory-opti:fix leak] fix world server leak#41

Merged
boubou19 merged 1 commit into
masterfrom
alex/fix-leak
Apr 14, 2026
Merged

[Memory-opti:fix leak] fix world server leak#41
boubou19 merged 1 commit into
masterfrom
alex/fix-leak

Conversation

@Alexdoru
Copy link
Copy Markdown
Member

@Alexdoru Alexdoru commented Apr 13, 2026

image

Copy link
Copy Markdown

@OvermindDL1 OvermindDL1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, this code looks good, and is disturbing that it leaked before, good find!

The failing build is entirely unrelated, that was just failing to acquire some RFG-standard-dependencies due to a maven server being down, nothing about FMP at all and if someone who has access (not me) can rerun the task then it should run now (I just tried it locally successfully so the maven server is back up).

As an aside, it's interesting that https://files.prismlauncher.org/maven/ is a maven repo in RFG, never noticed that before. Not something you'd expect to go down though so it's probably fine, but might be good to replicate the log4j variant they have (I could put it on my maven, which basically never goes down, like an hour total in 25 years) if that's the only thing it acquires from prisms site and it could be removed? But that's conversation for another time, and probably unnecessary anyway as I wouldn't guess prisms site goes down often regardless.

@boubou19 boubou19 enabled auto-merge (squash) April 14, 2026 14:42
@boubou19 boubou19 merged commit 1a4edfb into master Apr 14, 2026
1 of 2 checks passed
@boubou19 boubou19 deleted the alex/fix-leak branch April 14, 2026 14:48
@Alexdoru Alexdoru changed the title fix world server leak [Memory-opti:fix leak] fix world server leak Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants