Fix resource packs being reset on startup (symlink packs included)#31
Open
Eldrinn-Elantey wants to merge 1 commit intomasterfrom
Open
Fix resource packs being reset on startup (symlink packs included)#31Eldrinn-Elantey wants to merge 1 commit intomasterfrom
Eldrinn-Elantey wants to merge 1 commit intomasterfrom
Conversation
Avoid resetting selected resource packs during BetterLoadingScreen startup. - replace fragile reflection that grabbed an arbitrary List field in Minecraft with targeted lookup of defaultResourcePacks (and SRG fallback) - add safe fallback that detects the default pack list by mcDefaultResourcePack - stop calling mc.refreshResources() during early loading path - inject/remove BLS pack only through defaultResourcePacks with null/dup checks Result: selected packs (including symlink-based packs) are no longer dropped on startup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On client startup, enabled resource packs could be reset, which was especially visible with symlink-based packs.
This also broke expected font behavior because fonts are cached during startup.
Root cause
MinecraftDisplayerperformed early resource operations with:Listfield inMinecraftmc.refreshResources()calls during startup phaseThis could disturb resource-pack selection state.
Fix
getOnlyList()withgetDefaultResourcePackList():defaultResourcePacks/field_110449_aomc.mcDefaultResourcePackmc.refreshResources()callsdefaultResourcePackswith safety checksVerification
./gradlew compileJava -x testImpact
Low risk, targeted to startup resource-pack handling in BLS only.