Rotation function.#495
Open
DanielJohnWest wants to merge 2 commits intomainfrom
Open
Conversation
Rotation function to ensure correct phantom orientation across tests (SNR and uniformity fully working), PR 460 used for slice thickness, but slice position and geometric accuracy require further refinement.
Collaborator
|
Thanks for the PR! I've just had a quick look (looks great) and will properly review later. It looks like the unittests fail - do they fail your end? I imagine this is expected but it would be good to have some justification for changing test values in the form of a commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rotation function to ensure correct phantom orientation across tests (SNR and uniformity fully working), PR 460 used for slice thickness, but slice position and geometric accuracy require further refinement (relating to other open issues).