Update ACRObject.py with phantom rotation detection function.#453
Open
xleyn wants to merge 2 commits intoGSTT-CSC:mainfrom
Open
Update ACRObject.py with phantom rotation detection function.#453xleyn wants to merge 2 commits intoGSTT-CSC:mainfrom
xleyn wants to merge 2 commits intoGSTT-CSC:mainfrom
Conversation
Updated with new rotation function for testing
mollybuckley
requested changes
Dec 3, 2024
Collaborator
mollybuckley
left a comment
mollybuckley
left a comment
There was a problem hiding this comment.
Hi Nathan, this is great - thank you very much for doing this!
One minor change- please could you add docstrings following the same format as those in the other functions?
Thank you!
Updated with docstrings.
Collaborator
Author
|
Hi Molly, No problem! I've updated with the docstrings - anything else that needs changing? Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated with a phantom rotation detection function.
The function takes a greyscale image as an input and outputs the phantom's rotation angle!
The code works in my local python software although this is my first time using github so apologies if this doesn't work without some tweaks. However, I thought it was worth submitting as a start!