Fix Form Builder #1862
Merged
Fix Form Builder #1862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enhanced sortable initialization with error handling - Added visual feedback for drag operations - Fixed sort icons rendering issue - Added proper placeholder styling - Improved drag handle functionality - Added XHR request failure recovery Resolves form question ordering widget issues in Form Builder interface.
Fix: Form Builder Sort Functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the drag-and-drop functionality in a form builder, improving user experience and error handling. Key updates include new styles for draggable elements, better error handling in sortable operations, and the initialization of sortable functionality for various components such as questions, question options, and sections.
Drag-and-Drop Enhancements:
New styles for draggable elements:
.sort-placeholderand.drag-handlestyles to improve the visual appearance of sortable elements. These include dashed borders, background colors, and cursor changes for drag states. (app/assets/stylesheets/site.scss, app/assets/stylesheets/site.scssR373-R390)Improved error handling for sortable operations:
try-catchblocks to handle potential errors gracefully.app/views/components/forms/edit/_builder.html.erb, app/views/components/forms/edit/_builder.html.erbR262-R361)Initialization of Sortable Components:
Questions:
helper: 'clone'andtolerance: 'pointer'.app/views/components/forms/edit/_builder.html.erb, app/views/components/forms/edit/_builder.html.erbR262-R361)Question options:
app/views/components/forms/edit/_builder.html.erb, app/views/components/forms/edit/_builder.html.erbR262-R361)Sections:
app/views/components/forms/edit/_builder.html.erb, app/views/components/forms/edit/_builder.html.erbR262-R361)